[BE]: Apply PERF401 autofixes from ruff #140980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140980
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit a9eb0f7 with merge base e46af7d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: compiled autograd
facebook-github-bot
added
oncall: jit
Skylion007
force-pushed
the
skylion007/ruff-apply-perf401-2024-11-18
branch
from
793e5ea to
caa168b
Compare
Skylion007
added
release notes: performance_as_product
topic: not user facing
Skylion007
requested review from
EikanWang,
angelayi,
avikchaudhuri,
eqy,
gujinghui,
syed-ahmed,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
Skylion007
force-pushed
the
skylion007/ruff-apply-perf401-2024-11-18
branch
from
6f9bc48 to
a9eb0f7
Compare
justinchuby
approved these changes
Nov 19, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
Skylion007
requested review from
dzhulgakov,
lezcano,
ngimel and
peterbell10
malfet
reviewed
Nov 20, 2024
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM, let's try to merge it (and hopefully no land races)
Contributor
|
@pytorchbot merge |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
malfet
approved these changes
Nov 20, 2024
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Nov 21, 2024
Summary: * Automatically applies ruff rule 401. Turns loops into equivalent list comprehensions which are faster and do not leak the scope of the loop variables. * list comprehensions not only often have better typing, but are 50+% faster than for loops on overhead. They also preserve length information etc and are better for the interpreter to optimize. * Manually went back and made mypy happy after the change. * Also fixed style lints in files covered by flake8 but not by pyfmt X-link: pytorch/pytorch#140980 Approved by: https://github.com/justinchuby, https://github.com/malfet Reviewed By: izaitsevfb Differential Revision: D66262948 fbshipit-source-id: 4d871761b25633da20bca8d1f37b9842144f2218
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
* Automatically applies ruff rule 401. Turns loops into equivalent list comprehensions which are faster and do not leak the scope of the loop variables. * list comprehensions not only often have better typing, but are 50+% faster than for loops on overhead. They also preserve length information etc and are better for the interpreter to optimize. * Manually went back and made mypy happy after the change. * Also fixed style lints in files covered by flake8 but not by pyfmt Pull Request resolved: pytorch#140980 Approved by: https://github.com/justinchuby, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @ezyang @SherlockNoMad @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @LucasLLC @MeetVadakkanchery @mhorowitz @pradeepfn @xmfan