Skip to content

Add torch.sum dtype promotion description #140939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeshengzong wants to merge 2 commits into from
Closed

Add torch.sum dtype promotion description #140939

zeshengzong wants to merge 2 commits into from

Conversation

@zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Nov 18, 2024

Fixes #82159

Add note description about type promotion of torch.sum.

Test Result

Before
image

After
image

cc @mikaylagawarecki

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140939

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3e8d749 with merge base 06dde8c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Nov 18, 2024
@zeshengzong zeshengzong marked this pull request as ready for review November 18, 2024 09:34
@zou3519 zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2024
@zeshengzong
Copy link
Contributor Author

zeshengzong commented Nov 20, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@zeshengzong
Copy link
Contributor Author

zeshengzong commented Nov 20, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@zeshengzong
Add torch.sum dtype promotion description (pytorch#140939)
1a220a1 
Fixes pytorch#82159

Add note description about type promotion of `torch.sum`.

**Test Result**

**Before**
![image](https://github.com/user-attachments/assets/fb952676-f190-4680-9e15-ea8c99d33c67)

**After**
![image](https://github.com/user-attachments/assets/ee0d46a6-5053-46d5-b412-5c919a40965a)

Pull Request resolved: pytorch#140939
Approved by: https://github.com/zou3519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.sum promotes integral tensors to int64.

4 participants

@zeshengzong @pytorchmergebot @zou3519 @pytorchbot