[inductor] Add typing to ir.py 2 #140915
Closed
[inductor] Add typing to ir.py 2 #140915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140915
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5094cf5 with merge base e894219 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
aorenste
approved these changes
Nov 21, 2024
| elif reduction_size != op.get_reduction_size() or size != op.get_size(): | ||
| reduction_size = [*op.get_reduction_size()] | ||
| size = [*op.get_size()] | ||
| elif reduction_size != [*op.get_reduction_size()] or size != [ |
Contributor
There was a problem hiding this comment.
Why convert the returned sequence into a list? Optional[List[T]] should be comparable to Sequence[T]
Contributor
Author
There was a problem hiding this comment.
>>> (1, ) == [1, ]
False
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov