Skip to content

Address PR comments (canary) #140904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 13 commits into from
Closed

Address PR comments (canary) #140904

bobrenjc93 wants to merge 13 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Nov 17, 2024 •
edited by ezyang
Loading

@bobrenjc93
Address PR comments (canary)
af2fa14 
[ghstack-poisoned]
This was referenced Nov 17, 2024
Closed
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140904

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 37 New Failures, 1 Unrelated Failure

As of commit d98df69 with merge base c3fbec7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bobrenjc93 bobrenjc93 mentioned this pull request Nov 17, 2024
Closed
This was referenced Nov 17, 2024
Closed
Closed
Closed
Closed
Closed
@bobrenjc93 bobrenjc93 added topic: not user facing topic category keep-going Don't stop on first failure, keep running tests until the end labels Nov 17, 2024
@bobrenjc93
Update on "Address PR comments (canary)"
d67ecea 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
This was referenced Nov 17, 2024
Closed
Closed
@bobrenjc93
Update on "Address PR comments (canary)"
0357df8 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
21f73b7 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 18, 2024
Closed
@bobrenjc93
Update on "Address PR comments (canary)"
fac04be 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 19, 2024
Closed
@bobrenjc93
Update on "Address PR comments (canary)"
7aa42a1 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
4d4f0c2 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
c94880c 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
5b0057a 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
56177ec 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
bobrenjc93 and others added 3 commits November 19, 2024 15:30
@bobrenjc93
Update on "Address PR comments (canary)"
75ef1ae 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Address PR comments (canary)"
8e97a74 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@ezyang
Update
d98df69 
[ghstack-poisoned]
@bobrenjc93 bobrenjc93 closed this Nov 20, 2024
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
@bobrenjc93 @ezyang
Address PR comments (canary)
33d5e8b 
ghstack-source-id: 1f1e416
Pull Request resolved: pytorch/pytorch#140904
@github-actions github-actions bot deleted the gh/bobrenjc93/129/head branch December 22, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ciflow/inductor fx keep-going Don't stop on first failure, keep running tests until the end module: dynamo release notes: fx release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobrenjc93 @facebook-github-bot @ezyang