Skip to content

[Reland] Enable XPUEvent elapsed_time function #140873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guangyey wants to merge 12 commits into from
Closed

[Reland] Enable XPUEvent elapsed_time function #140873

guangyey wants to merge 12 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Nov 16, 2024 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Motivation

This PR intends to reland #134666 that has been reverted in #140872
We reverted it because I forgot to support elapsed_time for XPUGuardImpl, which resulted in c10::Event not supporting' elapsed_time' and blocking XPU CI.

Additional Context

We split #134666 into two parts: one part, PR #140865, supports elapsed_time for torch.Event and another one, this PR, supports for torch.xpu.elapsed_time.

cc @gujinghui @EikanWang @fengyuan14

@guangyey guangyey mentioned this pull request Nov 16, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140873

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 82df208 with merge base 9e299b8 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guangyey guangyey mentioned this pull request Nov 16, 2024
Closed
guangyey added a commit that referenced this pull request Nov 16, 2024
@guangyey
Enable XPUEvent elapsed_time function
6b6f5bd 
ghstack-source-id: 0afc2c6
Pull Request resolved: #140873
@guangyey guangyey marked this pull request as draft November 16, 2024 09:44
@guangyey guangyey changed the title Enable XPUEvent elapsed_time function [WIP] Enable XPUEvent elapsed_time function Nov 16, 2024
@guangyey guangyey changed the title [WIP] Enable XPUEvent elapsed_time function [WIP] [Reland] Enable XPUEvent elapsed_time function Nov 16, 2024
@guangyey
Update
26de521 
[ghstack-poisoned]
@guangyey
Update
800aa3a 
[ghstack-poisoned]
@guangyey
Update
6756866 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 18, 2024
@guangyey
Enable XPUEvent elapsed_time function
5f3ad08 
ghstack-source-id: 1af605d
Pull Request resolved: #140873
@guangyey guangyey added ciflow/xpu Run XPU CI tasks ciflow/trunk Trigger trunk jobs on your pull request module: xpu Intel XPU related issues release notes: xpu release notes category labels Nov 18, 2024
gujinghui
gujinghui reviewed Nov 18, 2024
View reviewed changes
@guangyey
Update
1074f80 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 19, 2024
@guangyey
Enable XPUEvent elapsed_time function
c976711 
ghstack-source-id: 15cfdfd
Pull Request resolved: #140873
@guangyey
Update
5e9f977 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 21, 2024
@guangyey
Enable XPUEvent elapsed_time function
76dafad 
ghstack-source-id: 33f52a3
Pull Request resolved: #140873
@riverliuintel riverliuintel mentioned this pull request Nov 21, 2024
Closed
@guangyey guangyey added this to the 2.6.0 milestone Nov 21, 2024
@guangyey
Update
0eafcf4 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 25, 2024
@guangyey
Enable XPUEvent elapsed_time function
00bae8b 
ghstack-source-id: 121b286
Pull Request resolved: #140873
@guangyey
Update
4581a18 
[ghstack-poisoned]
@guangyey
Update
8d5324f 
[ghstack-poisoned]
@guangyey
Update
6e5030b 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the ci-no-td Do not run TD on this PR label Nov 26, 2024
guangyey added a commit that referenced this pull request Nov 26, 2024
@guangyey
Enable XPUEvent elapsed_time function
edf9191 
ghstack-source-id: 928e102
Pull Request resolved: #140873
@guangyey guangyey changed the title [WIP] [Reland] Enable XPUEvent elapsed_time function [Reland] Enable XPUEvent elapsed_time function Nov 26, 2024
@guangyey guangyey marked this pull request as ready for review November 26, 2024 07:18
@guangyey
Update
830c4cb 
[ghstack-poisoned]
@guangyey
Update
d84c32e 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 27, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 27, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@guangyey
Update
82df208 
[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 27, 2024

Successfully rebased gh/guangyey/97/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/140873)

pytorchmergebot pushed a commit that referenced this pull request Nov 27, 2024
@guangyey
Enable XPUEvent elapsed_time function
7026711 
ghstack-source-id: 51acc1e
Pull Request resolved: #140873
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 28, 2024

"Unrelated failures, there is an issue to track it #141705"
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 28, 2024

Merge started

Your change will be merged while ignoring the following 2 checks: xpu / linux-jammy-xpu-2025_0-py3.9 / test (default, 1, 4, linux.idc.xpu), trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@guangyey
[Reland] Enable XPUEvent elapsed_time function (pytorch#140873)
2d84466 
# Motivation
This PR intends to reland pytorch#134666 that has been reverted in pytorch#140872
We reverted it because I forgot to support `elapsed_time` for `XPUGuardImpl`, which resulted in `c10::Event` not supporting' elapsed_time' and blocking XPU CI.

# Additional Context
We split pytorch#134666 into two parts: one part, PR pytorch#140865, supports `elapsed_time` for `torch.Event` and another one, this PR, supports for `torch.xpu.elapsed_time`.

Pull Request resolved: pytorch#140873
Approved by: https://github.com/gujinghui
ghstack dependencies: pytorch#140865
@vlad-penkin vlad-penkin mentioned this pull request Dec 5, 2024
Closed
@github-actions github-actions bot deleted the gh/guangyey/97/head branch December 30, 2024 02:07
@atalman atalman mentioned this pull request Jan 13, 2025
Closed
73 tasks
@dvrogozh dvrogozh mentioned this pull request Mar 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gujinghui gujinghui gujinghui approved these changes

@EikanWang EikanWang Awaiting requested review from EikanWang

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source release notes: xpu release notes category

Projects

PyTorch Intel
Status: Done

Milestone

2.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@guangyey @pytorchmergebot @gujinghui @pytorchbot