Revert "Enable XPUEvent elapsed_time function (#134666)" #140872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140872
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 88cc653 with merge base 2b39a8d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
added
ciflow/xpu
EikanWang
approved these changes
Nov 18, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 28, 2024
# Motivation This PR intends to reland #134666 that has been reverted in #140872 We reverted it because I forgot to support `elapsed_time` for `XPUGuardImpl`, which resulted in `c10::Event` not supporting' elapsed_time' and blocking XPU CI. # Additional Context We split #134666 into two parts: one part, PR #140865, supports `elapsed_time` for `torch.Event` and another one, this PR, supports for `torch.xpu.elapsed_time`. Pull Request resolved: #140873 Approved by: https://github.com/gujinghui ghstack dependencies: #140865
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…rch#140872) # Motivation This PR raises an internal UT failure on XPU. This reverts commit 4bbd6da. # Additional Context refer to pytorch#140814 Pull Request resolved: pytorch#140872 Approved by: https://github.com/EikanWang
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation This PR intends to reland pytorch#134666 that has been reverted in pytorch#140872 We reverted it because I forgot to support `elapsed_time` for `XPUGuardImpl`, which resulted in `c10::Event` not supporting' elapsed_time' and blocking XPU CI. # Additional Context We split pytorch#134666 into two parts: one part, PR pytorch#140865, supports `elapsed_time` for `torch.Event` and another one, this PR, supports for `torch.xpu.elapsed_time`. Pull Request resolved: pytorch#140873 Approved by: https://github.com/gujinghui ghstack dependencies: pytorch#140865
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
This reverts commit 4bbd6da. ghstack-source-id: adf484e Pull Request resolved: pytorch/pytorch#140872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
This PR raises an internal UT failure on XPU.
This reverts commit 4bbd6da.
Additional Context
refer to #140814
cc @gujinghui @EikanWang @fengyuan14