Skip to content

Specialize symfloats during equality checks #140830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 12 commits into from
Closed

Specialize symfloats during equality checks #140830

bobrenjc93 wants to merge 12 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Nov 15, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python test/inductor/test_torchinductor_opinfo.py TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32
when specialize_float=False

@bobrenjc93
NYI SymFloat equality
fb0b9a6 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140830

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2072dfb with merge base b86b534 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Nov 15, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Nov 15, 2024
bobrenjc93 added a commit that referenced this pull request Nov 16, 2024
@bobrenjc93
NYI SymFloat equality
d10488b 
ghstack-source-id: e980fa4
Pull Request resolved: #140830
@bobrenjc93 bobrenjc93 added the keep-going Don't stop on first failure, keep running tests until the end label Nov 16, 2024
@bobrenjc93 bobrenjc93 changed the title NYI SymFloat equality Specialize symfloats during equality checks Nov 16, 2024
@bobrenjc93
Update on "Specialize symfloats during equality checks"
d2856a1 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`



[ghstack-poisoned]
@bobrenjc93
Update on "Specialize symfloats during equality checks"
b08cfe6 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`



[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 16, 2024
Closed
@bobrenjc93
Update on "Specialize symfloats during equality checks"
2072dfb 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`



[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 17, 2024
Closed
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Nov 17, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@bobrenjc93 bobrenjc93 mentioned this pull request Nov 17, 2024
Closed
This was referenced Nov 17, 2024
Closed
Closed
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2024
@bobrenjc93 @pytorchmergebot
Specialize symfloats when getting fake value involves complex args (#…
e1d6c08 
…140832)

Fixed `PYTORCH_TEST_WITH_DYNAMO=1 tlp python test/test_sparse_csr.py TestSparseCSRCPU.test_sampled_addmm_cpu_complex64` when `specialize_float=False`

Pull Request resolved: #140832
Approved by: https://github.com/ezyang
ghstack dependencies: #140830
pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2024
@bobrenjc93 @pytorchmergebot
don't specialize when grad tracking tensors are activated (#140828)
9005156 
Fixes `python test/dynamo/test_inline_inbuilt_nn_modules.py
InlineInbuiltNNModulesFuncTorchHigherOrderOpTests.test_grad_non_tensor_input_inline_inbuilt_nn_modules`
when `specialize_float=False`

Pull Request resolved: #140828
Approved by: https://github.com/ezyang
ghstack dependencies: #140830, #140832
pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2024
@bobrenjc93 @pytorchmergebot
Add trunc to z3 validator (#140886)
9f4af6b 
Fixes vision_maskrcnn benchmark when validation is turned on

Pull Request resolved: #140886
Approved by: https://github.com/ezyang
ghstack dependencies: #140830, #140832, #140828
cyyever pushed a commit to cyyever/pytorch that referenced this pull request Nov 20, 2024
@bobrenjc93 @cyyever
Add trunc to z3 validator (pytorch#140886)
2589384 
Fixes vision_maskrcnn benchmark when validation is turned on

Pull Request resolved: pytorch#140886
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832, pytorch#140828
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@bobrenjc93 @Ryo-not-rio
Specialize symfloats during equality checks (pytorch#140830)
250e07c 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`

Pull Request resolved: pytorch#140830
Approved by: https://github.com/ezyang
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@bobrenjc93 @Ryo-not-rio
Specialize symfloats when getting fake value involves complex args (p…
5112b13 
…ytorch#140832)

Fixed `PYTORCH_TEST_WITH_DYNAMO=1 tlp python test/test_sparse_csr.py TestSparseCSRCPU.test_sampled_addmm_cpu_complex64` when `specialize_float=False`

Pull Request resolved: pytorch#140832
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@bobrenjc93 @Ryo-not-rio
don't specialize when grad tracking tensors are activated (pytorch#14…
200b377 
…0828)

Fixes `python test/dynamo/test_inline_inbuilt_nn_modules.py
InlineInbuiltNNModulesFuncTorchHigherOrderOpTests.test_grad_non_tensor_input_inline_inbuilt_nn_modules`
when `specialize_float=False`

Pull Request resolved: pytorch#140828
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@bobrenjc93 @Ryo-not-rio
Add trunc to z3 validator (pytorch#140886)
1776b89 
Fixes vision_maskrcnn benchmark when validation is turned on

Pull Request resolved: pytorch#140886
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832, pytorch#140828
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@bobrenjc93
Specialize symfloats during equality checks (pytorch#140830)
4dd15e9 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`

Pull Request resolved: pytorch#140830
Approved by: https://github.com/ezyang
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@bobrenjc93
Specialize symfloats when getting fake value involves complex args (p…
b6e070d 
…ytorch#140832)

Fixed `PYTORCH_TEST_WITH_DYNAMO=1 tlp python test/test_sparse_csr.py TestSparseCSRCPU.test_sampled_addmm_cpu_complex64` when `specialize_float=False`

Pull Request resolved: pytorch#140832
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@bobrenjc93
don't specialize when grad tracking tensors are activated (pytorch#14…
1e2d36a 
…0828)

Fixes `python test/dynamo/test_inline_inbuilt_nn_modules.py
InlineInbuiltNNModulesFuncTorchHigherOrderOpTests.test_grad_non_tensor_input_inline_inbuilt_nn_modules`
when `specialize_float=False`

Pull Request resolved: pytorch#140828
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@bobrenjc93
Add trunc to z3 validator (pytorch#140886)
9d459cf 
Fixes vision_maskrcnn benchmark when validation is turned on

Pull Request resolved: pytorch#140886
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832, pytorch#140828
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
@bobrenjc93 @fmo-mt
Specialize symfloats during equality checks (pytorch#140830)
6715fdf 
Fixes `PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=0 python
    test/inductor/test_torchinductor_opinfo.py
    TestInductorOpInfoCPU.test_comprehensive_nn_functional_local_response_norm_cpu_float32`
    when `specialize_float=False`

Pull Request resolved: pytorch#140830
Approved by: https://github.com/ezyang
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
@bobrenjc93 @fmo-mt
Specialize symfloats when getting fake value involves complex args (p…
9c393b4 
…ytorch#140832)

Fixed `PYTORCH_TEST_WITH_DYNAMO=1 tlp python test/test_sparse_csr.py TestSparseCSRCPU.test_sampled_addmm_cpu_complex64` when `specialize_float=False`

Pull Request resolved: pytorch#140832
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
@bobrenjc93 @fmo-mt
don't specialize when grad tracking tensors are activated (pytorch#14…
c25f181 
…0828)

Fixes `python test/dynamo/test_inline_inbuilt_nn_modules.py
InlineInbuiltNNModulesFuncTorchHigherOrderOpTests.test_grad_non_tensor_input_inline_inbuilt_nn_modules`
when `specialize_float=False`

Pull Request resolved: pytorch#140828
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832
fmo-mt pushed a commit to fmo-mt/pytorch that referenced this pull request Dec 11, 2024
@bobrenjc93 @fmo-mt
Add trunc to z3 validator (pytorch#140886)
2674e24 
Fixes vision_maskrcnn benchmark when validation is turned on

Pull Request resolved: pytorch#140886
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140830, pytorch#140832, pytorch#140828
@github-actions github-actions bot deleted the gh/bobrenjc93/123/head branch December 19, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobrenjc93 @pytorchmergebot @ezyang