🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140756

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit aa9ebe7 with merge base f5e6e52 ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot rebase -b main

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/main gh/isuruf/105/orig returned non-zero exit code 1

warning: skipped previously applied commit 235bdd50675
warning: skipped previously applied commit e1cd32f85c0
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config set advice.skippedCherryPicks false"
Rebasing (1/1)
Auto-merging torch/_dynamo/config.py
CONFLICT (content): Merge conflict in torch/_dynamo/config.py
error: could not apply 5cbcd49d70d... Enable C++ dynamic shape guards by default
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 5cbcd49d70d... Enable C++ dynamic shape guards by default

Raised by https://github.com/pytorch/pytorch/actions/runs/15841087008

@pytorchbot rebase -b viable/strict

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Successfully rebased gh/isuruf/105/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/140756)

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

The performance impact of this seems significant (see vllm-project/vllm#26320). I did notice this was turned off in fbcode by default, and that's not a good sign. Can we consider either (1) working towards aligning the fbcode and non-fbcode defaults and/or (2) benchmarking this even more to get data?

@anijain2305 @laithsakka.

This was turned off in fbcode because of issues with compiling sources on the fly internally AFAIK. @ezyang and @anijain2305 might be able to shed some light on that.

Yes, if there are lots of recompiles, this might have a negative performance impact. On the other hand, this PR makes the runtime faster if the compilation time is ignored. Let's discuss in the linked issue.