[reland] [aoti] Selectively package AOTI generated files #140675
Conversation
Summary: Reland pytorch#140022 Test Plan: CI Differential Revision: D65929964
angelayi
requested review from
avikchaudhuri,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140675
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit ccf8fd2 with merge base 62eea62 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D65929964 |
desertfire
left a comment
desertfire
left a comment
There was a problem hiding this comment.
Nit: you may take this opportunity to reword the title a bit since it's not about remove dir now.
angelayi
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f -m "landed internally" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "landed internally" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
) Summary: Reland pytorch#140022 Test Plan: CI Differential Revision: D65929964 Pull Request resolved: pytorch#140675 Approved by: https://github.com/desertfire
Summary: #140675 adds logic to collect all the generated cubin file paths into an additional_files list, but the collection should only happen when DeferredGpuKernelLine is materialized. This is to prepare for one-pass AOTI CUDA codegen. Differential Revision: [D66718227](https://our.internmc.facebook.com/intern/diff/D66718227) Pull Request resolved: #141979 Approved by: https://github.com/chenyang78 ghstack dependencies: #141388, #141387
Summary: #140675 adds logic to collect all the generated cubin file paths into an additional_files list, but the collection should only happen when DeferredGpuKernelLine is materialized. This is to prepare for one-pass AOTI CUDA codegen. Differential Revision: [D66718227](https://our.internmc.facebook.com/intern/diff/D66718227) Pull Request resolved: #141979 Approved by: https://github.com/chenyang78 ghstack dependencies: #141388, #141387
5 participants
Summary: Reland #140022
Test Plan: CI
Differential Revision: D65929964
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov