Skip to content

[ROCm][Inductor][CK] Enable scaled mm with bias in gemm max autotune with CK backend #140674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tenpercent wants to merge 10 commits into from
Closed

[ROCm][Inductor][CK] Enable scaled mm with bias in gemm max autotune with CK backend #140674

tenpercent wants to merge 10 commits into from

Conversation

@tenpercent
Copy link
Collaborator

@tenpercent tenpercent commented Nov 14, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140674

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 10c7d7e with merge base ebeab26 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm module: inductor module: rocm AMD GPU support for Pytorch labels Nov 14, 2024
@tenpercent
Copy link
Collaborator Author

tenpercent commented Nov 14, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 14, 2024
@tenpercent tenpercent marked this pull request as ready for review November 14, 2024 21:59
@tenpercent tenpercent changed the title [ROCm][Inductor][CK] Enable scaled mm with bias [ROCm][Inductor][CK] Enable scaled mm with bias in gemm max autotune with CK backend Nov 14, 2024
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 15, 2024
chenyang78
chenyang78 approved these changes Nov 15, 2024
View reviewed changes
Copy link

@chenyang78 chenyang78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tenpercent
Copy link
Collaborator Author

tenpercent commented Nov 15, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 15, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 15, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@tenpercent
Copy link
Collaborator Author

tenpercent commented Nov 15, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 15, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 15, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@tenpercent
Copy link
Collaborator Author

tenpercent commented Nov 15, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 15, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@tenpercent
Copy link
Collaborator Author

tenpercent commented Nov 15, 2024

Link #125453

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@tenpercent
[ROCm][Inductor][CK] Enable scaled mm with bias in gemm max autotune …
0118935 
…with CK backend (pytorch#140674)

## Testing
```
pytest test/inductor/test_ck_backend.py -k scaled_mm
```

Pull Request resolved: pytorch#140674
Approved by: https://github.com/chenyang78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ColinPeppler ColinPeppler Awaiting requested review from ColinPeppler

1 more reviewer

@chenyang78 chenyang78 chenyang78 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tenpercent @pytorchmergebot @chenyang78 @pytorchbot @mikaylagawarecki