Skip to content

Refine XPU device prop and fix typo #140661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guangyey wants to merge 2 commits into from
Closed

Refine XPU device prop and fix typo #140661

guangyey wants to merge 2 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Nov 14, 2024 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Motivation

architecture is an experimental attribute that might been used by triton AOT codegen. It should not be in __repr__.

cc @gujinghui @EikanWang @fengyuan14

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 14, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140661

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit c29f941 with merge base 62eea62 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guangyey guangyey added module: xpu Intel XPU related issues ciflow/xpu Run XPU CI tasks release notes: xpu release notes category topic: not user facing topic category labels Nov 14, 2024
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024
@chuanqi129 chuanqi129 mentioned this pull request Nov 14, 2024
Closed
18 tasks
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 14, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 14, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 14, 2024

Successfully rebased gh/guangyey/94/orig onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/140661)

pytorchmergebot pushed a commit that referenced this pull request Nov 14, 2024
@guangyey
Refine XPU device prop and fix typo
29ea763 
ghstack-source-id: 588e7db
Pull Request resolved: #140661
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 14, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 14, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey
Update
23f76d2 
[ghstack-poisoned]
@guangyey
Update
c29f941 
[ghstack-poisoned]
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@guangyey
Refine XPU device prop and fix typo (pytorch#140661)
4c4a905 
# Motivation
`architecture` is an experimental attribute that might been used by triton AOT codegen. It should not be in `__repr__`.

Pull Request resolved: pytorch#140661
Approved by: https://github.com/EikanWang
@github-actions github-actions bot deleted the gh/guangyey/94/head branch December 15, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EikanWang EikanWang EikanWang approved these changes

@gujinghui gujinghui Awaiting requested review from gujinghui

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source release notes: xpu release notes category topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guangyey @pytorchmergebot @EikanWang @pytorchbot