[Reland][Environment Variable][5/N] Use thread-safe getenv functions #140594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
requested review from
IvanYashchuk,
eqy,
lezcano,
nikitaved and
syed-ahmed
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140594
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit 2a475fc with merge base b379a28 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added
the
triaged
ezyang
approved these changes
Nov 18, 2024
Contributor
|
@pytorchbot merge -r |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
|
Successfully rebased |
pytorchmergebot
force-pushed
the
env12_reland
branch
from
e9e4a5a to
2a475fc
Compare
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#140594) Reland of pytorch#139762 with no bug found. Pull Request resolved: pytorch#140594 Approved by: https://github.com/ezyang
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…functions (#140594)" Summary: Failed to write the auto-tune result to `PYTORCH_TUNABLEOP_FILENAME` with this change (empty file) , reverting to unblock. Test Plan: CI Differential Revision: D66870750
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 7, 2024
…functions (#140594)" (#142226) Summary: Failed to write the auto-tune result to `PYTORCH_TUNABLEOP_FILENAME` with this change (empty file) , reverting to unblock. Test Plan: CI Differential Revision: D66870750 Pull Request resolved: #142226 Approved by: https://github.com/leitian
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
…functions (pytorch#140594)" (pytorch#142226) Summary: Failed to write the auto-tune result to `PYTORCH_TUNABLEOP_FILENAME` with this change (empty file) , reverting to unblock. Test Plan: CI Differential Revision: D66870750 Pull Request resolved: pytorch#142226 Approved by: https://github.com/leitian
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2024
Fixes #142403 ~~PR fixes breakage due to this commit 8cd7ad8b48a187df36bdc9ac1fcaf25db950eed6~~ PR is a partial reland of this #140594 with a unit test. Pull Request resolved: #142274 Approved by: https://github.com/jeffdaily, https://github.com/eqy
naromero77amd
added a commit
to ROCm/pytorch
that referenced
this pull request
Apr 9, 2025
Fixes pytorch#142403 ~~PR fixes breakage due to this commit pytorch@8cd7ad8b48a187df36bdc9ac1fcaf25db950eed6~~ PR is a partial reland of this pytorch#140594 with a unit test. Pull Request resolved: pytorch#142274 Approved by: https://github.com/jeffdaily, https://github.com/eqy (cherry picked from commit dcb128d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #139762 with no bug found.