Skip to content

Move complex<Half> from Half.h to complex.h #140565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swolchok wants to merge 3 commits into from
Closed

Move complex<Half> from Half.h to complex.h #140565

swolchok wants to merge 3 commits into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Nov 13, 2024 •
edited
Loading

@swolchok
Move complex<Half> from Half.h to complex.h
b72566b 
Executing on old TODO on the way to sharing Half.h with ExecuTorch.

Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140565

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 72d085a with merge base 891ba2e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 13, 2024

This pull request was exported from Phabricator. Differential Revision: D65888037

This was referenced Nov 13, 2024
Closed
Closed
Closed
@swolchok swolchok added the topic: not user facing topic category label Nov 13, 2024
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024
@swolchok
Update on "Move complex<Half> from Half.h to complex.h"
e67d7b8 
Executing on old TODO on the way to sharing Half.h with ExecuTorch.

Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Nov 14, 2024
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 14, 2024

This pull request was exported from Phabricator. Differential Revision: D65888037

@swolchok
Update on "Move complex<Half> from Half.h to complex.h"
72d085a 
Executing on old TODO on the way to sharing Half.h with ExecuTorch.

Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 14, 2024

This pull request was exported from Phabricator. Differential Revision: D65888037

@malfet
Copy link
Contributor

malfet commented Nov 18, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 18, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 18, 2024
@swolchok @pytorchmergebot
Add C10_EMBEDDED to gate ostream usage in Half/BFloat16 (#140566)
f59ec98 
We want to use Half/BFloat16 in ExecuTorch to support shared kernel code. They will need to be used in ExecuTorch core, so they can't have streams. This diff introduces a macro to gate the stream code off.

Differential Revision: [D65888035](https://our.internmc.facebook.com/intern/diff/D65888035/)
Pull Request resolved: #140566
Approved by: https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: #140564, #140565
pytorchmergebot pushed a commit that referenced this pull request Nov 18, 2024
@swolchok @pytorchmergebot
Remove UB type punning from c10/util/floating_point_utils.h (#140567)
081c168 
Accessing the inactive member of a union is undefined behavior. Fortunately, we have c10::bit_cast.

Differential Revision: [D65888680](https://our.internmc.facebook.com/intern/diff/D65888680/)
Pull Request resolved: #140567
Approved by: https://github.com/Skylion007, https://github.com/malfet
ghstack dependencies: #140564, #140565, #140566
pytorchmergebot pushed a commit that referenced this pull request Nov 18, 2024
@swolchok @pytorchmergebot
Port X86_F16 from executorch half to PyTorch half (#140720)
17bb78a 
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature.

Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
Pull Request resolved: #140720
Approved by: https://github.com/malfet
ghstack dependencies: #140564, #140565, #140566, #140567
@swolchok swolchok mentioned this pull request Nov 19, 2024
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2024

This pull request was exported from Phabricator. Differential Revision: D65888037

@swolchok swolchok mentioned this pull request Nov 19, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 19, 2024
@swolchok @pytorchmergebot
Fix Half X86_F16 CUDA build failure (#140994)
efed02b 
It passed PyTorch CI, but internally we saw failures from this.

Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/)
Pull Request resolved: #140994
Approved by: https://github.com/malfet
ghstack dependencies: #140564, #140565, #140566, #140567, #140720
pytorchmergebot pushed a commit that referenced this pull request Nov 19, 2024
@swolchok @pytorchmergebot
Use std::bit_cast as c10::bit_cast if available (#141035)
f30f43f 
Make what we're doing as obvious as possible to the compiler.

Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)
Pull Request resolved: #141035
Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: #140564, #140565, #140566, #140567, #140720, #140994
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Move complex<Half> from Half.h to complex.h (pytorch#140565)
99f34d4 
Executing on old TODO on the way to sharing Half.h with ExecuTorch.

Differential Revision: [D65888037](https://our.internmc.facebook.com/intern/diff/D65888037/)
Pull Request resolved: pytorch#140565
Approved by: https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: pytorch#140564
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Add C10_EMBEDDED to gate ostream usage in Half/BFloat16 (pytorch#140566)
d0848ff 
We want to use Half/BFloat16 in ExecuTorch to support shared kernel code. They will need to be used in ExecuTorch core, so they can't have streams. This diff introduces a macro to gate the stream code off.

Differential Revision: [D65888035](https://our.internmc.facebook.com/intern/diff/D65888035/)
Pull Request resolved: pytorch#140566
Approved by: https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: pytorch#140564, pytorch#140565
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Remove UB type punning from c10/util/floating_point_utils.h (pytorch#…
26cdc9d 
…140567)

Accessing the inactive member of a union is undefined behavior. Fortunately, we have c10::bit_cast.

Differential Revision: [D65888680](https://our.internmc.facebook.com/intern/diff/D65888680/)
Pull Request resolved: pytorch#140567
Approved by: https://github.com/Skylion007, https://github.com/malfet
ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Port X86_F16 from executorch half to PyTorch half (pytorch#140720)
b614c64 
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature.

Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
Pull Request resolved: pytorch#140720
Approved by: https://github.com/malfet
ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Fix Half X86_F16 CUDA build failure (pytorch#140994)
b8eb551 
It passed PyTorch CI, but internally we saw failures from this.

Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/)
Pull Request resolved: pytorch#140994
Approved by: https://github.com/malfet
ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@swolchok
Use std::bit_cast as c10::bit_cast if available (pytorch#141035)
b0a2889 
Make what we're doing as obvious as possible to the compiler.

Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/)
Pull Request resolved: pytorch#141035
Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swolchok @facebook-github-bot @malfet @pytorchmergebot @ezyang