Skip to content

[BE][accelerator] formalize API name {current,set}_device_{idx => index} #140542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
XuehaiPan wants to merge 7 commits into from
Closed

[BE][accelerator] formalize API name {current,set}_device_{idx => index} #140542

XuehaiPan wants to merge 7 commits into from

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Nov 13, 2024 •
edited
Loading

@XuehaiPan
Update
4cb812d 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140542

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2626d83 with merge base 2903cf0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan XuehaiPan added the topic: not user facing topic category label Nov 13, 2024
@XuehaiPan XuehaiPan requested a review from guangyey November 13, 2024 12:55
@XuehaiPan
Update
f76082d 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from albanD as a code owner November 13, 2024 15:05
XuehaiPan added a commit that referenced this pull request Nov 13, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
1d72c8a 
…dex}`

ghstack-source-id: 9451a19
Pull Request resolved: #140542
@guangyey
Copy link
Collaborator

guangyey commented Nov 14, 2024

Good to me, it needs Alban's final stamp.

@XuehaiPan
Update
e887ae8 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Nov 14, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
2fdf0ac 
…dex}`

ghstack-source-id: 0609955
Pull Request resolved: #140542
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Dec 9, 2024

@albanD could you take a look at this?

albanD
albanD reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both names seemed used so no strong opinion here. I guess these are new enough that we can change them.

@XuehaiPan
Update
59afc8b 
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from albanD December 10, 2024 07:51
@XuehaiPan
Update
018d5f2 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 10, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
c155eb4 
…dex}`

ghstack-source-id: c957cf5
Pull Request resolved: #140542
albanD
albanD approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@guangyey
Copy link
Collaborator

guangyey commented Dec 11, 2024

@XuehaiPan Could you help clean up {idx => index} in https://github.com/pytorch/pytorch/blob/main/test/test_accelerator.py

@XuehaiPan
Update
e9e9c6e 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 11, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
02b649b 
…dex}`

ghstack-source-id: 37da54f
Pull Request resolved: #140542
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Dec 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 11, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 11, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Dec 11, 2024

@pytorchbot revert -m 'Sorry for reverting your change, but I need to revert this in order to revert #133572 (comment) due to a conflict' -c weird

Please help rebase and reland this

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 11, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 11, 2024

@XuehaiPan your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 11, 2024
@pytorchmergebot
Revert "[BE][accelerator] formalize API name `{current,set}_device_{i…
cd50bd8 
…dx => index}` (#140542)"

This reverts commit fb02b40.

Reverted #140542 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but I need to revert this in order to revert #133572 (comment) due to a conflict ([comment](#140542 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 11, 2024
@XuehaiPan
Update
2626d83 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Dec 12, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
919e4ae 
…dex}`

ghstack-source-id: 15456de
Pull Request resolved: #140542
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Dec 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey guangyey mentioned this pull request Dec 13, 2024
Closed
@guangyey
Copy link
Collaborator

guangyey commented Dec 13, 2024

@albanD Do you think if this PR should cherry pick to release/2.6

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Dec 13, 2024
@XuehaiPan
[BE][accelerator] formalize API name `{current,set}_device_{idx => in…
9da8414 
…dex}` (pytorch#140542)

Pull Request resolved: pytorch#140542
Approved by: https://github.com/guangyey, https://github.com/albanD
This was referenced Dec 13, 2024
Merged
Closed
kit1980 pushed a commit that referenced this pull request Dec 18, 2024
@XuehaiPan
[Reland 2.6][BE][accelerator] formalize API name `{current,set}_devic…
22775e0 
…e_{idx => index}` (#143186)

[BE][accelerator] formalize API name `{current,set}_device_{idx => index}` (#140542)

Pull Request resolved: #140542
Approved by: https://github.com/guangyey, https://github.com/albanD
@github-actions github-actions bot deleted the gh/XuehaiPan/200/head branch January 14, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@guangyey guangyey guangyey approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@XuehaiPan @guangyey @pytorchmergebot @huydhn @albanD @pytorchbot