-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[dyanmo] support subclasses of namedtuple type #140534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140534
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 8898bca with merge base 8a80cee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests?
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "stuck at infinite ci queue" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Allow subclassing namedtuple type. Allow assign attributes to instances of these subtypes. X-link: pytorch/pytorch#140534 Approved by: https://github.com/jansel Reviewed By: izaitsevfb Differential Revision: D66080719 fbshipit-source-id: 5a20fa5e7908234bc6eebb0ad1a7dcd727931b62
Allow subclassing namedtuple type. Allow assign attributes to instances of these subtypes. Pull Request resolved: pytorch#140534 Approved by: https://github.com/jansel
Allow subclassing namedtuple type. Allow assign attributes to instances of these subtypes.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames