Skip to content

Optimize hook description of register_module_forward_hook #140379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeshengzong wants to merge 2 commits into from
Closed

Optimize hook description of register_module_forward_hook #140379

zeshengzong wants to merge 2 commits into from

Conversation

@zeshengzong
Copy link
Contributor

@zeshengzong zeshengzong commented Nov 12, 2024 •
edited
Loading

Fixes #74024

Optimize description as the issue suggested

cc @albanD @jbschlosser

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140379

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 29a6011 with merge base 3acc6ea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@zeshengzong zeshengzong marked this pull request as ready for review November 12, 2024 10:49
@zeshengzong
Copy link
Contributor Author

zeshengzong commented Nov 12, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 12, 2024
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 13, 2024
mikaylagawarecki
mikaylagawarecki approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mikaylagawarecki mikaylagawarecki added release notes: nn release notes category topic: docs topic category and removed topic: not user facing topic category labels Nov 21, 2024
@mikaylagawarecki
Copy link
Contributor

mikaylagawarecki commented Nov 21, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 21, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor

mikaylagawarecki commented Nov 21, 2024

Please fix lint

@zeshengzong
Copy link
Contributor Author

zeshengzong commented Nov 22, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2024

Merge failed

Reason: 19 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@fffrog
Copy link
Collaborator

fffrog commented Nov 22, 2024

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2024

Successfully rebased opt/docs/4 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout opt/docs/4 && git pull --rebase)

@zeshengzong
Copy link
Contributor Author

zeshengzong commented Nov 22, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 22, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@zeshengzong
Optimize hook description of register_module_forward_hook (pytorch#14…
8500635 
…0379)

Fixes pytorch#74024

Optimize description as the issue suggested

Pull Request resolved: pytorch#140379
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ambiguous docstring on register_module_forward_hook

6 participants

@zeshengzong @mikaylagawarecki @pytorchmergebot @fffrog @soulitzer @pytorchbot