Skip to content

Fix xpu cmake typo #140374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guangyey wants to merge 1 commit into from
Closed

Fix xpu cmake typo #140374

guangyey wants to merge 1 commit into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Nov 12, 2024 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Motivation

This PR aims to fix a typo in the CMake build. The typo impacts the XPU Windows build and results in PyTorch being built without XPU, which is unexpected.

cc @gujinghui @EikanWang @fengyuan14

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140374

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 825f2e0 with merge base 330c957 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey added a commit that referenced this pull request Nov 12, 2024
@guangyey
fix xpu cmake typo
f88e3ec 
ghstack-source-id: d006c7e
Pull Request resolved: #140374
@guangyey guangyey marked this pull request as draft November 12, 2024 08:27
@guangyey guangyey changed the title fix xpu cmake typo Fix xpu cmake typo Nov 12, 2024
@guangyey guangyey added the ciflow/xpu Run XPU CI tasks label Nov 12, 2024
@guangyey guangyey marked this pull request as ready for review November 12, 2024 08:48
@guangyey guangyey added release notes: xpu release notes category topic: bug fixes topic category labels Nov 12, 2024
@chuanqi129 chuanqi129 mentioned this pull request Nov 12, 2024
Closed
18 tasks
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2024
@guangyey guangyey requested a review from atalman November 12, 2024 09:03
@EikanWang EikanWang added the topic: not user facing topic category label Nov 12, 2024
@guangyey
Copy link
Collaborator Author

guangyey commented Nov 12, 2024 •
edited
Loading

@atalman Sorry for that. This typo error caused an unexpected build behavior, resulting in the XPU build on Windows falling back to a CPU-only binary. Currently, XPU CI for Windows has not been enabled to capture similar issues due to the limitation of XPU CI infrastructure. But we comprehensively run test cases to guarantee the code quality locally, which might not expose the issue immediately.

@guangyey guangyey added the module: xpu Intel XPU related issues label Nov 12, 2024
@guangyey guangyey requested review from ezyang and malfet November 12, 2024 09:19
@ezyang
Copy link
Contributor

ezyang commented Nov 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge failed

Reason: HTTP Error 504: Gateway Timeout

Details for Dev Infra team Raised by workflow job

@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 12, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge failed

Reason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-py3.9 / test (default, 2, 4, linux.idc.xpu)

Details for Dev Infra team Raised by workflow job

atalman
atalman approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guangyey
Update
825f2e0 
[ghstack-poisoned]
@EikanWang
Copy link
Collaborator

EikanWang commented Nov 13, 2024

This failure was introduced by a particular PR yesterday. Because the test case does not support Intel GPU, we will refine the test case and fix the failure in another PR.

@EikanWang
Copy link
Collaborator

EikanWang commented Nov 13, 2024

@pytorchbot merge -i "Irrelevant CI failure"

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: Irrelevant CI failure

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@EikanWang
Copy link
Collaborator

EikanWang commented Nov 13, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: xpu / linux-jammy-xpu-py3.9 / test (default, 2, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhangxiaoli73 pushed a commit to zhangxiaoli73/pytorch that referenced this pull request Nov 13, 2024
@guangyey @zhangxiaoli73
Fix xpu cmake typo (pytorch#140374)
0e4cbeb 
# Motivation
This PR aims to fix a typo in the CMake build. The typo impacts the XPU Windows build and results in PyTorch being built without XPU, which is unexpected.

Pull Request resolved: pytorch#140374
Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman
zero000064 pushed a commit to zero000064/pytorch that referenced this pull request Nov 14, 2024
@guangyey @zero000064
Fix xpu cmake typo (pytorch#140374)
4d2b84b 
# Motivation
This PR aims to fix a typo in the CMake build. The typo impacts the XPU Windows build and results in PyTorch being built without XPU, which is unexpected.

Pull Request resolved: pytorch#140374
Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman
Ryo-not-rio pushed a commit to Ryo-not-rio/pytorch that referenced this pull request Dec 2, 2024
@guangyey @Ryo-not-rio
Fix xpu cmake typo (pytorch#140374)
76aa839 
# Motivation
This PR aims to fix a typo in the CMake build. The typo impacts the XPU Windows build and results in PyTorch being built without XPU, which is unexpected.

Pull Request resolved: pytorch#140374
Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@guangyey
Fix xpu cmake typo (pytorch#140374)
256aaa9 
# Motivation
This PR aims to fix a typo in the CMake build. The typo impacts the XPU Windows build and results in PyTorch being built without XPU, which is unexpected.

Pull Request resolved: pytorch#140374
Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman
@github-actions github-actions bot deleted the gh/guangyey/93/head branch December 14, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@atalman atalman atalman approved these changes

@EikanWang EikanWang EikanWang approved these changes

@jgong5 jgong5 Awaiting requested review from jgong5

@gujinghui gujinghui Awaiting requested review from gujinghui

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source release notes: xpu release notes category topic: bug fixes topic category topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@guangyey @ezyang @pytorchmergebot @Skylion007 @EikanWang @atalman @pytorchbot