Skip to content

log_softmax: fix meta function output argument dtype check. #140289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ysiraichi wants to merge 3 commits into from
Closed

log_softmax: fix meta function output argument dtype check. #140289

ysiraichi wants to merge 3 commits into from

Conversation

@ysiraichi
Copy link
Collaborator

@ysiraichi ysiraichi commented Nov 11, 2024 •
edited
Loading

@ysiraichi
Update
ca9dfda 
[ghstack-poisoned]
@ysiraichi ysiraichi requested a review from mruberry as a code owner November 11, 2024 18:22
This was referenced Nov 11, 2024
Closed
Closed
Closed
@ysiraichi ysiraichi mentioned this pull request Nov 11, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140289

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 237a812 with merge base ffb9790 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ysiraichi ysiraichi mentioned this pull request Nov 11, 2024
Open
@ysiraichi
Rebased.
b998c05 
[ghstack-poisoned]
@ysiraichi ysiraichi added the topic: not user facing topic category label Nov 11, 2024
@ysiraichi
Update
237a812 
[ghstack-poisoned]
ysiraichi added a commit that referenced this pull request Nov 12, 2024
@ysiraichi
log_softmax: fix meta function output argument dtype check.
3d15c89 
Tracking issue: #138399

ghstack-source-id: bedc320
Pull Request resolved: #140289
@ysiraichi ysiraichi requested a review from ezyang November 12, 2024 19:13
@ezyang
Copy link
Contributor

ezyang commented Nov 13, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 13, 2024

Merge failed

Reason: PR #140288 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ysiraichi
Copy link
Collaborator Author

ysiraichi commented Nov 18, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 18, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@ysiraichi
log_softmax: fix meta function output argument dtype check. (pytorc…
b54eefe 
…h#140289)

Tracking issue: pytorch#138399
Pull Request resolved: pytorch#140289
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#140186, pytorch#140286, pytorch#140288
@github-actions github-actions bot deleted the gh/ysiraichi/73/head branch December 19, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ysiraichi @ezyang @pytorchmergebot @pytorchbot