Fix unary references' out dtype check. #140288
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140288
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5ed8aee with merge base ffb9790 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Tracking issue: pytorch#138399 This PR fixes a number of reference implementations (which are also used as meta functions), making them more consistent with CPU device. More specifically, it fixes those operations that use `_make_elementwise_unary_reference` decorator, and don't error on mismatching out argument dtype while they error when using concrete devices (e.g. CPU). The fixed operations are: - `abs` - `ceil` - `floor` - `frac` - `isneginf` - `isposinf` - `sgn` - `sign` - `signbit` - `trunc` Pull Request resolved: pytorch#140288 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140186, pytorch#140286
…h#140289) Tracking issue: pytorch#138399 Pull Request resolved: pytorch#140289 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140186, pytorch#140286, pytorch#140288
4 participants
Stack from ghstack (oldest at bottom):
log_softmax: fix meta function output argument dtype check. #140289triangular_solve: fix meta function output argument dtype check. #140286triangular_solvemeta function out parameter names. #140186Tracking issue: #138399
This PR fixes a number of reference implementations (which are also used as meta
functions), making them more consistent with CPU device. More specifically, it fixes those
operations that use
_make_elementwise_unary_referencedecorator, and don't error onmismatching out argument dtype while they error when using concrete devices (e.g. CPU).
The fixed operations are:
absceilfloorfracisneginfisposinfsgnsignsignbittrunc