Skip to content

[AOTI XPU] Support AOT Inductor for Intel GPU. #140269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etaf wants to merge 28 commits into from
Closed

[AOTI XPU] Support AOT Inductor for Intel GPU. #140269

etaf wants to merge 28 commits into from

Conversation

@etaf
Copy link
Collaborator

@etaf etaf commented Nov 11, 2024 •
edited by desertfire
Loading

@etaf
Update
b9f1d97 
[ghstack-poisoned]
This was referenced Nov 11, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140269

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit c37ff96 with merge base f84e533 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@etaf etaf mentioned this pull request Nov 10, 2024
Closed
@etaf etaf mentioned this pull request Nov 11, 2024
Closed
etaf added a commit that referenced this pull request Nov 11, 2024
@etaf
[AOIT] Support AOT Inductor for Intel GPU.
4eb17d2 
ghstack-source-id: c146fd7
Pull Request resolved: #140269
@etaf etaf marked this pull request as draft November 11, 2024 15:00
@etaf
Update
e11a1a1 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Nov 12, 2024
@etaf
[AOIT] Support AOT Inductor for Intel GPU.
175eb02 
ghstack-source-id: 76f316a
Pull Request resolved: #140269
@etaf etaf added the ciflow/xpu Run XPU CI tasks label Nov 12, 2024
@etaf
Update
11c8ed7 
[ghstack-poisoned]
etaf added a commit that referenced this pull request Nov 12, 2024
@etaf
[AOIT] Support AOT Inductor for Intel GPU.
6af308f 
ghstack-source-id: fbf029c
Pull Request resolved: #140269
@etaf
Update
4835a2c 
[ghstack-poisoned]
@etaf etaf mentioned this pull request Nov 14, 2024
Closed
@etaf
Update
7e788e4 
[ghstack-poisoned]
@etaf etaf mentioned this pull request Nov 14, 2024
Closed
@etaf etaf marked this pull request as ready for review November 14, 2024 08:38
@etaf etaf requested a review from desertfire November 14, 2024 08:41
@clee2000
Copy link
Contributor

clee2000 commented Dec 9, 2024

@pytorchbot revert -m "breaks forward compatibility? D66937097" -c ghfirst

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!! Forward compatibility breakage detected !!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

These symbols are declared in model so, but not in fbpkg:
aoti_torch_device_type_xpu

@desertfire Could you help take a look at this?

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Dec 9, 2024
@pytorchmergebot
Revert "[AOTI] Fix #140546 and support AOTI package load for Intel GP…
6fcb294 
…U. (#140664)"

This reverts commit 91d3054.

Reverted #140664 on behalf of https://github.com/clee2000 due to breaks forward compatibility?  D66937097 ([comment](#140269 (comment)))
pytorchmergebot added a commit that referenced this pull request Dec 9, 2024
@pytorchmergebot
Revert "[AOTI XPU] Support AOT Inductor for Intel GPU. (#140269)"
219e9c8 
This reverts commit 854d831.

Reverted #140269 on behalf of https://github.com/clee2000 due to breaks forward compatibility?  D66937097 ([comment](#140269 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 9, 2024

@etaf your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 9, 2024
@desertfire
Update on "[AOTI XPU] Support AOT Inductor for Intel GPU."
740465a 
This PR add XPU support for AOT Inductor, and reuse the corresponding UT.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Dec 9, 2024
@desertfire
Update base for Update on "[AOTI] Fix #140546 and support AOTI packag…
7c7ed2c 
…e load for Intel GPU."

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* #140686
* __->__ #140664
* #140269
* #140268
* #135320
* #135318
* #139026 


Fix #140546



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Dec 9, 2024
@desertfire
Update on "[AOTI] Fix #140546 and support AOTI package load for Intel…
cd6ca16 
… GPU."

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* #140686
* __->__ #140664
* #140269
* #140268
* #135320
* #135318
* #139026 


Fix #140546



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
@desertfire
Copy link
Contributor

desertfire commented Dec 9, 2024

These symbols are declared in model so, but not in fbpkg:
aoti_torch_device_type_xpu


@desertfire Could you help take a look at this?

I added a missing #ifdef USE_XPU in aoti_runtime/model.h, and tested it passes in fbcode.

@desertfire
Update on "[AOTI XPU] Support AOT Inductor for Intel GPU."
c37ff96 
This PR add XPU support for AOT Inductor, and reuse the corresponding UT.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Dec 9, 2024
@desertfire
Update base for Update on "[AOTI] Fix #140546 and support AOTI packag…
9779a9b 
…e load for Intel GPU."

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* #140686
* __->__ #140664
* #140269
* #140268
* #135320
* #135318
* #139026 


Fix #140546



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Dec 9, 2024
@desertfire
Update on "[AOTI] Fix #140546 and support AOTI package load for Intel…
2abadda 
… GPU."

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* #140686
* __->__ #140664
* #140269
* #140268
* #135320
* #135318
* #139026 


Fix #140546



cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov

[ghstack-poisoned]
@malfet
Copy link
Contributor

malfet commented Dec 9, 2024

Also, this test is breaking Mac testing, although results were initially occluded by #142206

@desertfire
Copy link
Contributor

desertfire commented Dec 9, 2024

Also, this test is breaking Mac testing, although results were initially occluded by #142206

Do you have a test failure link? I wonder what the problem is.

@etaf
Copy link
Collaborator Author

etaf commented Dec 10, 2024

Also, this test is breaking Mac testing, although results were initially occluded by #142206

Do you have a test failure link? I wonder what the problem is.

Seems not relate to this PR: #142436

@etaf
Copy link
Collaborator Author

etaf commented Dec 10, 2024

The failed job :xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 4, 4, linux.idc.xpu) (gh)
inductor/test_torchinductor_opinfo.py::TestInductorOpInfoXPU::test_comprehensive_masked_cumprod_xpu_float16

is a known issue #141861 and has been fixed in main branch by #142348.

Please ignore it.

pytorchmergebot pushed a commit that referenced this pull request Dec 10, 2024
@desertfire @pytorchmergebot
[AOTI] Fix #140546 and support AOTI package load for Intel GPU. (#140664
1cb2ebd 
)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* #140686
* __->__ #140664
* #140269
* #140268
* #135320
* #135318
* #139026

Fix #140546

Pull Request resolved: #140664
Approved by: https://github.com/desertfire, https://github.com/EikanWang
ghstack dependencies: #140268, #140269

Co-authored-by: Bin Bao <[email protected]>
mori360 pushed a commit to mori360/pytorch that referenced this pull request Dec 11, 2024
@desertfire @mori360
[AOTI XPU] Support AOT Inductor for Intel GPU. (pytorch#140269)
391f740 
This PR add XPU support for AOT Inductor, and reuse the corresponding UT.

Pull Request resolved: pytorch#140269
Approved by: https://github.com/desertfire, https://github.com/EikanWang
ghstack dependencies: pytorch#140268

Co-authored-by: Bin Bao <[email protected]>
mori360 pushed a commit to mori360/pytorch that referenced this pull request Dec 11, 2024
@desertfire @mori360
[AOTI] Fix pytorch#140546 and support AOTI package load for Intel GPU. (
16ac64d 
pytorch#140664)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* pytorch#140686
* __->__ pytorch#140664
* pytorch#140269
* pytorch#140268
* pytorch#135320
* pytorch#135318
* pytorch#139026

Fix pytorch#140546

Pull Request resolved: pytorch#140664
Approved by: https://github.com/desertfire, https://github.com/EikanWang
ghstack dependencies: pytorch#140268, pytorch#140269

Co-authored-by: Bin Bao <[email protected]>
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
@pytorchmergebot @bluenote10
Revert "[AOTI] Fix pytorch#140546 and support AOTI package load for I…
b9b3352 
…ntel GPU. (pytorch#140664)"

This reverts commit 91d3054.

Reverted pytorch#140664 on behalf of https://github.com/clee2000 due to breaks forward compatibility?  D66937097 ([comment](pytorch#140269 (comment)))
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
@pytorchmergebot @bluenote10
Revert "[AOTI XPU] Support AOT Inductor for Intel GPU. (pytorch#140269)"
ebec281 
This reverts commit 854d831.

Reverted pytorch#140269 on behalf of https://github.com/clee2000 due to breaks forward compatibility?  D66937097 ([comment](pytorch#140269 (comment)))
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
@desertfire @bluenote10
[AOTI XPU] Support AOT Inductor for Intel GPU. (pytorch#140269)
0f4fc56 
This PR add XPU support for AOT Inductor, and reuse the corresponding UT.

Pull Request resolved: pytorch#140269
Approved by: https://github.com/desertfire, https://github.com/EikanWang
ghstack dependencies: pytorch#140268

Co-authored-by: Bin Bao <[email protected]>
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
@desertfire @bluenote10
[AOTI] Fix pytorch#140546 and support AOTI package load for Intel GPU. (
694318d 
pytorch#140664)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* pytorch#140686
* __->__ pytorch#140664
* pytorch#140269
* pytorch#140268
* pytorch#135320
* pytorch#135318
* pytorch#139026

Fix pytorch#140546

Pull Request resolved: pytorch#140664
Approved by: https://github.com/desertfire, https://github.com/EikanWang
ghstack dependencies: pytorch#140268, pytorch#140269

Co-authored-by: Bin Bao <[email protected]>
Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024
@etaf
[AOIT] Support AOT Inductor for Intel GPU.
0c1bd5a 
ghstack-source-id: 57a71ac
Pull Request resolved: pytorch/pytorch#140269
@github-actions github-actions bot deleted the gh/etaf/60/head branch January 11, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guangyey guangyey guangyey left review comments

@desertfire desertfire desertfire approved these changes

@EikanWang EikanWang EikanWang approved these changes

@avikchaudhuri avikchaudhuri Awaiting requested review from avikchaudhuri

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

@ydwu4 ydwu4 Awaiting requested review from ydwu4

@angelayi angelayi Awaiting requested review from angelayi

@gujinghui gujinghui Awaiting requested review from gujinghui

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/xpu Run XPU CI tasks Merged module: inductor open source release notes: export Reverted

Projects

PyTorch Intel
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@etaf @EikanWang @clee2000 @pytorchmergebot @desertfire @malfet @guangyey @pytorchbot