[Intel GPU] Support getStreamFromExternel for XPU. #140268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140268
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 61ef5a3 with merge base f84e533 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 11, 2024
Collaborator
|
@etaf , pls. provide informative description to elaborate on why you need to do such changes. |
Collaborator
Author
resolved. |
desertfire
approved these changes
Nov 20, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 7, 2024
This PR add XPU support for AOT Inductor, and reuse the corresponding UT. Pull Request resolved: #140269 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 7, 2024
) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 Pull Request resolved: #140664 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268, #140269
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
In AOT inductor scenario, the GPU Stream can be created outside of the pool of `XPUStream`, and we need to create a `XPUStream` which refers to this stream for the the common logic of AOTI, for example a stream guard is a guard for `XPUStream`. So we add the getStreamFromExternel following the design of CUDAStream. Pull Request resolved: pytorch#140268 Approved by: https://github.com/desertfire, https://github.com/jansel, https://github.com/EikanWang
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
This PR add XPU support for AOT Inductor, and reuse the corresponding UT. Pull Request resolved: #140269 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 Pull Request resolved: #140664 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268, #140269
desertfire
added a commit
that referenced
this pull request
Dec 9, 2024
…e load for Intel GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Dec 9, 2024
… GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Dec 9, 2024
…e load for Intel GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
desertfire
added a commit
that referenced
this pull request
Dec 9, 2024
… GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2024
This PR add XPU support for AOT Inductor, and reuse the corresponding UT. Pull Request resolved: #140269 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268 Co-authored-by: Bin Bao <[email protected]>
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2024
) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 Pull Request resolved: #140664 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268, #140269 Co-authored-by: Bin Bao <[email protected]>
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
ghstack-source-id: c2db7d2 Pull Request resolved: pytorch/pytorch#140268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
In AOT inductor scenario, the GPU Stream can be created outside of the pool of
XPUStream, and we need to create aXPUStreamwhich refers to this stream for the the common logic of AOTI, for example a stream guard is a guard forXPUStream. So we add the getStreamFromExternel following the design of CUDAStream.