Skip to content

[BE][Ez]: Add NT unary op macro #140213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Skylion007 wants to merge 1 commit into from
Closed

[BE][Ez]: Add NT unary op macro #140213

Skylion007 wants to merge 1 commit into from

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Nov 9, 2024

  • Adds a macro to simplify adding more unary ops to NT.
  • Adds sqrt support to NT

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140213

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e7c5840 with merge base f77eb07 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added release notes: nested tensor Changes that have a direct impact on nested tensors better-engineering Relatively self-contained tasks for better engineering contributors labels Nov 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

drisspg
drisspg reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jbschlosser Looks like a good idea to me though

jbschlosser
jbschlosser approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I'm good with this :) Thanks!

@jbschlosser jbschlosser added the topic: not user facing topic category label Nov 12, 2024
@jbschlosser
Copy link
Contributor

jbschlosser commented Nov 12, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Skylion007
Copy link
Collaborator Author

Skylion007 commented Nov 12, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Successfully rebased skylion007/add-nt-unary-op-macro-2024-11-09 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/add-nt-unary-op-macro-2024-11-09 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the skylion007/add-nt-unary-op-macro-2024-11-09 branch from d650b8f to e7c5840 Compare November 12, 2024 16:17
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 12, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@Skylion007
[BE][Ez]: Add NT unary op macro (pytorch#140213)
93939e2 
* Adds a macro to simplify adding more unary ops to NT.
* Adds sqrt support to NT
Pull Request resolved: pytorch#140213
Approved by: https://github.com/jbschlosser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drisspg drisspg drisspg left review comments

@jbschlosser jbschlosser jbschlosser approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@cpuhrsch cpuhrsch Awaiting requested review from cpuhrsch

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nested tensor Changes that have a direct impact on nested tensors topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Skylion007 @jbschlosser @pytorchmergebot @drisspg @pytorchbot