[dynamo] Remove closure_cells and merge/remove code paths
#140154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140154
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit ccca419 with merge base f98c601 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 8, 2024
This was referenced Nov 9, 2024
This was referenced Nov 12, 2024
Contributor
Author
|
Rebase. |
jansel
approved these changes
Nov 13, 2024
| # but we'll do it again here so that we don't need to push a dummy variable. | ||
| # We shouldn't actually be doing anything with this variable anyway. | ||
| self.push(self._load_closure(name), name=name) | ||
| elif name.startswith("."): |
Member
There was a problem hiding this comment.
Do we still need this condition?
Contributor
Author
There was a problem hiding this comment.
Honestly idk, but happy to take a look. This doesn't seem immediately related to closure cells so I didn't touch it.
Member
There was a problem hiding this comment.
guess if the tests are passing, it's probably fine then?
Contributor
Author
There was a problem hiding this comment.
Oh I didn't realize I removed the condition lol. Lemme bring it back just to be safe, I'll take a look into this renaming separately.
smalltalkman
pushed a commit
to smalltalkman/pytorch
that referenced
this pull request
Nov 15, 2024
…ytorch#140155) This is no longer needed now that we've replaced `ClosureVariable` with `NewCellVariable`, i.e., Dynamo now treats `LOAD_CLOSURE` the same as `LOAD_FAST`. Pull Request resolved: pytorch#140155 Approved by: https://github.com/jansel, https://github.com/williamwen42 ghstack dependencies: pytorch#140330, pytorch#140152, pytorch#140436, pytorch#140435, pytorch#140153, pytorch#140154
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…140154) Now that all cells are modeled as `NewCellVariable` in Dynamo, we no longer need to put cell variables into this special `closure_cells`, rather we just merge `closure_cells` with `symbolic_locals`. This allows us to merge and remove some code paths, notably make `LOAD_CLOSURE` the same as `LOAD_FAST`, and `LOAD_DEREF` & `STORE_DEREF` the same for inlining or regular `InstructionTranslator`. Pull Request resolved: pytorch#140154 Approved by: https://github.com/jansel ghstack dependencies: pytorch#140330, pytorch#140152, pytorch#140436, pytorch#140435, pytorch#140153
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#140155) This is no longer needed now that we've replaced `ClosureVariable` with `NewCellVariable`, i.e., Dynamo now treats `LOAD_CLOSURE` the same as `LOAD_FAST`. Pull Request resolved: pytorch#140155 Approved by: https://github.com/jansel, https://github.com/williamwen42 ghstack dependencies: pytorch#140330, pytorch#140152, pytorch#140436, pytorch#140435, pytorch#140153, pytorch#140154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
name_stackcode paths insymbolic_convert.py#140155closure_cellsand merge/remove code paths #140154NewCellVariable#140153prune_dead_object_new#140435ExecutionRecorderonly in root frameInstructionTranslator#140152DynamoFrameTypetype above Python frame object #140330Now that all cells are modeled as
NewCellVariablein Dynamo, we nolonger need to put cell variables into this special
closure_cells,rather we just merge
closure_cellswithsymbolic_locals.This allows us to merge and remove some code paths, notably make
LOAD_CLOSUREthe same asLOAD_FAST, andLOAD_DEREF&STORE_DEREFthe same for inlining or regular
InstructionTranslator.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames