[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #140041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

larryliu0820 wants to merge 1 commit into main from export-D65586230

Contributor

larryliu0820 commented Nov 7, 2024

Summary:
Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

Updating miniz library from version 2.0.8 -> 2.1.0 #79636 patches internal BUCK and bazel build
reimport pr137735 due to merging check issues #138959 adds bool compute_crc32 argument
miniz PR: Read comp_size, decomp_size and local_header_ofs for zip64 if extra fields exist richgel999/miniz#324 to support
zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan:
Rely on unit test

Imported from OSS

Differential Revision: D65586230

larryliu0820 requested a review from mikaylagawarecki as a code owner

November 7, 2024 20:00

pytorch-bot bot commented Nov 7, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140041

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 611bc6f with merge base dfcf740 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

facebook-github-bot added the fb-exported label

larryliu0820 added the topic: not user facing label

larryliu0820 force-pushed the export-D65586230 branch from 1d2df9e to 39fe446 Compare

November 7, 2024 21:32

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

mikaylagawarecki reviewed

View reviewed changes

third_party/miniz-3.0.2/miniz.c Outdated Show resolved Hide resolved

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 39fe446 to f8d2a1e Compare

November 7, 2024 22:25

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from f8d2a1e to 149e875 Compare

November 7, 2024 22:36

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 149e875 to a041a46 Compare

November 7, 2024 23:00

larryliu0820 force-pushed the export-D65586230 branch from a041a46 to 6bf2f24 Compare

November 7, 2024 23:09

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

1 similar comment

Contributor

facebook-github-bot commented Nov 7, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 6bf2f24 to 8ef86ef Compare

November 7, 2024 23:20

larryliu0820 added a commit that referenced this pull request


          [miniz] Bump miniz version to 3.0.2 and add patch for zip64 (#140041)

8ef86ef

Summary:
Pull Request resolved: #140041

Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

* #79636 patches internal BUCK and bazel build
* #138959 adds `bool compute_crc32` argument
* miniz PR: richgel999/miniz#324 to support
  zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan:
Rely on unit test

Imported from OSS

Differential Revision: D65586230

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 8ef86ef to 749240d Compare

November 8, 2024 04:32

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 added a commit that referenced this pull request


          [miniz] Bump miniz version to 3.0.2 and add patch for zip64 (#140041)

f7301f1

Summary:
Pull Request resolved: #140041

Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

* #79636 patches internal BUCK and bazel build
* #138959 adds `bool compute_crc32` argument
* miniz PR: richgel999/miniz#324 to support
  zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan:
Rely on unit test

Imported from OSS

Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 749240d to f7301f1 Compare

November 8, 2024 04:40

mikaylagawarecki approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

1 similar comment

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from f7301f1 to 049ea13 Compare

November 8, 2024 17:38


          [miniz] Bump miniz version to 3.0.2 and add patch for zip64 (#140041)

611bc6f

Summary:
Pull Request resolved: #140041

Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

* #79636 patches internal BUCK and bazel build
* #138959 adds `bool compute_crc32` argument
* miniz PR: richgel999/miniz#324 to support
  zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan:
Rely on unit test

Imported from OSS

Reviewed By: mikaylagawarecki, angelayi

Differential Revision: D65586230

Contributor

facebook-github-bot commented Nov 8, 2024

This pull request was exported from Phabricator. Differential Revision: D65586230

larryliu0820 force-pushed the export-D65586230 branch from 049ea13 to 611bc6f Compare

November 8, 2024 18:33

Contributor

facebook-github-bot commented Nov 9, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Nov 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

a02e88d

pytorchmergebot removed the merging label

angelayi mentioned this pull request

Fails to export and run llama3.2-1b. RuntimeError: Failed to initialize zip archive: invalid header or archive is corrupted pytorch/torchchat#1357

Closed

larryliu0820 added a commit that referenced this pull request


          [miniz] Make sure miniz extra_size_remaining doesn't go off bound

197113c

#140041 added some logic to fix a zip64 header error. This PR makes sure `extra_size_remaining` doesn't overflow.

larryliu0820 mentioned this pull request

[miniz] Make sure miniz extra_size_remaining doesn't go off bound #141266

Closed

pytorchmergebot pushed a commit that referenced this pull request


          [miniz] Make sure miniz extra_size_remaining doesn't go off bound (#1…

e28b095

…41266)

#140041 added some logic to fix a zip64 header error. This PR makes sure `extra_size_remaining` doesn't overflow.

Pull Request resolved: #141266
Approved by: https://github.com/angelayi

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          [miniz] Bump miniz version to 3.0.2 and add patch for zip64 (pytorch#…

46f016d

…140041)

Summary:
Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

* pytorch#79636 patches internal BUCK and bazel build
* pytorch#138959 adds `bool compute_crc32` argument
* miniz PR: richgel999/miniz#324 to support
  zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan:
Rely on unit test

Imported from OSS

Differential Revision: D65586230

Pull Request resolved: pytorch#140041
Approved by: https://github.com/mikaylagawarecki

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request


          [miniz] Make sure miniz extra_size_remaining doesn't go off bound (py…

61e4c3b

…torch#141266)

pytorch#140041 added some logic to fix a zip64 header error. This PR makes sure `extra_size_remaining` doesn't overflow.

Pull Request resolved: pytorch#141266
Approved by: https://github.com/angelayi

github-actions bot deleted the export-D65586230 branch

December 9, 2024 02:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged topic: not user facing