[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

larryliu0820 · 2024-11-07T07:04:30Z

Stack from ghstack (oldest at bottom):

-> [miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

Summary:

Bump miniz version from 2.1.0 to 3.0.2 and apply these patches:

Updating miniz library from version 2.0.8 -> 2.1.0 #79636 patches internal BUCK and bazel build
reimport pr137735 due to merging check issues #138959 adds bool compute_crc32 argument
miniz PR: Read comp_size, decomp_size and local_header_ofs for zip64 if extra fields exist richgel999/miniz#324 to support
zip64

Anyone bumping miniz version again, please apply these patches as well.

Test Plan: Rely on unit test

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D65586230

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2024-11-07T07:04:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139985

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit a72f39d with merge base c03324d ():

NEW FAILURES - The following jobs have failed:

pull / cuda12.1-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu) (gh)
REGRESSION: benchmark ('add_loop_eager', 'compile_time_instruction_count') failed, actual result 3084108072 is 1.55% higher than expected 3037000000 ±+1.50% if this is an expected regression, please update the expected results.
pull / linux-focal-py3.11-clang10 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh)
test_serialization.py::TestSerialization::test_filewriter_metadata_writing_filename_False
pull / linux-focal-py3.12-clang10 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge) (gh)
test_serialization.py::TestSerialization::test_filewriter_metadata_writing_filename_False
pull / linux-focal-py3.9-clang10 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh)
test_serialization.py::TestSerialization::test_filewriter_metadata_writing_filename_False
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh)
test_serialization.py::TestSerialization::test_filewriter_metadata_writing_filename_False

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

larryliu0820 · 2024-11-07T07:14:52Z

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D65586230](https://our.internmc.facebook.com/intern/diff/D65586230) [ghstack-poisoned]

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4501669 Pull Request resolved: #139985

larryliu0820 · 2024-11-07T08:01:44Z

@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mikaylagawarecki

I think you might need to apply some of the other patches from here https://github.com/pytorch/pytorch/commits/main/third_party/miniz-2.1.0/miniz.c and https://github.com/pytorch/pytorch/commits/main/third_party/miniz-2.1.0/miniz.h in order for CI to pass

Thanks for helping to apply the changes I made and documenting clearly

third_party/miniz-3.0.2/miniz.h

github-actions · 2025-01-07T14:16:14Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

larryliu0820 requested a review from mikaylagawarecki as a code owner November 7, 2024 07:04

larryliu0820 requested a review from angelayi November 7, 2024 07:04

larryliu0820 added the topic: not user facing topic category label Nov 7, 2024

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2024

Skylion007 approved these changes Nov 7, 2024

View reviewed changes

mikaylagawarecki reviewed Nov 7, 2024

View reviewed changes

third_party/miniz-3.0.2/miniz.h Show resolved Hide resolved

angelayi approved these changes Nov 8, 2024

View reviewed changes

github-actions bot added the Stale label Jan 7, 2025

github-actions bot closed this Feb 6, 2025

github-actions bot deleted the gh/larryliu0820/45/head branch March 9, 2025 01:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

Uh oh!

larryliu0820 commented Nov 7, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Nov 7, 2024 •

edited

Loading

Uh oh!

larryliu0820 commented Nov 7, 2024

Uh oh!

larryliu0820 commented Nov 7, 2024

Uh oh!

mikaylagawarecki left a comment •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

Uh oh!

Conversation

larryliu0820 commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139985

❌ 5 New Failures, 1 Unrelated Failure

Uh oh!

larryliu0820 commented Nov 7, 2024

Uh oh!

larryliu0820 commented Nov 7, 2024

Uh oh!

mikaylagawarecki left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

larryliu0820 commented Nov 7, 2024 •

edited

Loading

pytorch-bot bot commented Nov 7, 2024 •

edited

Loading

mikaylagawarecki left a comment •

edited

Loading