[BE] Remove warn about using Half on CPUs #139961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
the
module: cpu
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139961
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f7adcd with merge base 59cf4bc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jgong5
approved these changes
Nov 7, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 7, 2024
It's strange that it has not been implemented for the type yet Pull Request resolved: #139959 Approved by: https://github.com/jgong5, https://github.com/janeyx99 ghstack dependencies: #139961
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl` Fixes #139723 Pull Request resolved: #139960 Approved by: https://github.com/kimishpatel ghstack dependencies: #139961, #139959
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Was added by pytorch#33021, but modern CPUs right now are quite capable of handling half precision types. Alternatively one can guard the warning with `#ifdef x86_64` Pull Request resolved: pytorch#139961 Approved by: https://github.com/jgong5
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
It's strange that it has not been implemented for the type yet Pull Request resolved: pytorch#139959 Approved by: https://github.com/jgong5, https://github.com/janeyx99 ghstack dependencies: pytorch#139961
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl` Fixes pytorch#139723 Pull Request resolved: pytorch#139960 Approved by: https://github.com/kimishpatel ghstack dependencies: pytorch#139961, pytorch#139959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Was added by #33021, but modern CPUs right now are quite capable of handling half precision types.
Alternatively one can guard the warning with
#ifdef x86_64cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10