Skip to content

Extend CPU implementation of MSELoss to BF16 #139959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

Extend CPU implementation of MSELoss to BF16 #139959

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 7, 2024 •
edited
Loading

@malfet
Update
f2eebf6 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139959

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fc94519 with merge base 59cf4bc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Nov 7, 2024
This was referenced Nov 7, 2024
Closed
Closed
@malfet malfet requested review from ezyang and jgong5 November 7, 2024 02:03
jgong5
jgong5 approved these changes Nov 7, 2024
View reviewed changes
@malfet malfet added the topic: not user facing topic category label Nov 7, 2024
@malfet malfet mentioned this pull request Nov 7, 2024
Open
@malfet malfet added the ci-no-td Do not run TD on this PR label Nov 7, 2024
@malfet
Update
fc94519 
[ghstack-poisoned]
@malfet malfet requested a review from mruberry as a code owner November 7, 2024 16:50
@malfet
Copy link
Contributor Author

malfet commented Nov 7, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 7, 2024

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

janeyx99
janeyx99 approved these changes Nov 7, 2024
View reviewed changes
torch/testing/_internal/common_methods_invocations.py
Copy link
Contributor

@janeyx99 janeyx99 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right

@malfet
Copy link
Contributor Author

malfet commented Nov 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 7, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 7, 2024

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x f58ec4cfd39e0b6e16a15e2577011788cc290ec2 returned non-zero exit code 1

Auto-merging aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
Auto-merging torch/testing/_internal/common_methods_invocations.py
error: could not apply f58ec4cfd39... Extend CPU implementation of MSELoss to BF16
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Nov 7, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 7, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 8, 2024
@malfet @pytorchmergebot
[MPS] Restrict MSELoss to floating types (#139960)
103cbd7 
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU

Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out
Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl`

Fixes #139723
Pull Request resolved: #139960
Approved by: https://github.com/kimishpatel
ghstack dependencies: #139961, #139959
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@malfet
Extend CPU implementation of MSELoss to BF16 (pytorch#139959)
b92a534 
It's strange that it has not been implemented for the type yet

Pull Request resolved: pytorch#139959
Approved by: https://github.com/jgong5, https://github.com/janeyx99
ghstack dependencies: pytorch#139961
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@malfet
[MPS] Restrict MSELoss to floating types (pytorch#139960)
a451f5b 
Becuase if invoked with long type it crahses deep in MPSGraph framework and to keep parity with CPU

Add test that validates that if dtype is not floating, both CPU and MPS implementations will error out
Fix function name for `mse_loss_out_mps` as `__func__` for any structured op implementation is `impl`

Fixes pytorch#139723
Pull Request resolved: pytorch#139960
Approved by: https://github.com/kimishpatel
ghstack dependencies: pytorch#139961, pytorch#139959
@github-actions github-actions bot deleted the gh/malfet/51/head branch December 8, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgong5 jgong5 jgong5 approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @jgong5 @janeyx99