[ONNX] Prioritize strict=False export strategy #139905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
requested review from
shubhambhokare1,
titaiwangms and
wschin
as code owners
pytorch-bot
bot
added
the
release notes: onnx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139905
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c2ac074 with merge base 99deedf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justinchuby
added
module: onnx
titaiwangms
approved these changes
Nov 6, 2024
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xadupre
approved these changes
Nov 6, 2024
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Prioritize the `strict=False` export strategy in ONNX export because it is preferred according to @SherlockNoMad Pull Request resolved: pytorch#139905 Approved by: https://github.com/titaiwangms, https://github.com/xadupre
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prioritize the
strict=Falseexport strategy in ONNX export because bypasses dynamo errors for full graph tracing and is preferred according to @SherlockNoMad