-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Fix torch.load (torch.utils.benchmark) after #137602 #139810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139810
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2f0cf92 with merge base 59b6694 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Let's add a TODO to allowlist required things via |
Good point! Let me try to see if I can do this in the correct way now instead of adding another TODO |
|
I'll add the TODO then, I try to update the code snippet generated by the test to use |
|
@pytorchbot merge -f 'Previous run has passed, this only add a TODO comment' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…139810) After pytorch#137602, the default `weights_only` has been set to True. This test is failing in trunk slow jobs atm benchmark_utils/test_benchmark_utils.py::TestBenchmarkUtils::test_collect_callgrind [GH job link](https://github.com/pytorch/pytorch/actions/runs/11672436111/job/32502454946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/1aa71be56c39908893273bd9558b127159e1ef3a) Pull Request resolved: pytorch#139810 Approved by: https://github.com/kit1980
…139810) After pytorch#137602, the default `weights_only` has been set to True. This test is failing in trunk slow jobs atm benchmark_utils/test_benchmark_utils.py::TestBenchmarkUtils::test_collect_callgrind [GH job link](https://github.com/pytorch/pytorch/actions/runs/11672436111/job/32502454946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/1aa71be56c39908893273bd9558b127159e1ef3a) Pull Request resolved: pytorch#139810 Approved by: https://github.com/kit1980
After #137602, the default
weights_onlyhas been set to True. This test is failing in trunk slow jobs atmbenchmark_utils/test_benchmark_utils.py::TestBenchmarkUtils::test_collect_callgrind GH job link HUD commit link