Fix for T206766523 ("Your diff, D65462767, broke some tests") #139804

fduwjj · 2024-11-05T21:54:11Z

Summary:
This is trying to fix a regression caused by #139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported.

Reviewed By: fduwjj

Differential Revision: D65490202

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o

pytorch-bot · 2024-11-05T21:54:15Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139804

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a72fc18 with merge base 2ee91db ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2024-11-05T21:54:16Z

The committers listed above are authorized under a signed CLA.

✅ login: fduwjj / name: Junjie Wang (a72fc18)

facebook-github-bot · 2024-11-05T21:54:24Z

This pull request was exported from Phabricator. Differential Revision: D65490202

…h#139804) Summary: This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T206766523: - The agent searched for and edited the files it deemed relevant for fixing the tests - After generating the patch, the broken test(s) were rerun to verify they now pass - Regression tests were also run to verify CI still passes --- **If this diff is the correct fix for T206766523, please accept the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!* **If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed. --- *P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.* Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//inference_enablement/model_processing/tests:ien_publish_in_trainer_tests -- --exact 'inference_enablement/model_processing/tests:ien_publish_in_trainer_tests - test_sp_in_trainer_publish (inference_enablement.model_processing.tests.ien_publish_in_trainer_tests.IENPublishInTrainerTests)' ``` https://www.internalfb.com/intern/testinfra/testrun/10977524148369514 Differential Revision: D65490202

facebook-github-bot · 2024-11-05T21:59:15Z

This pull request was exported from Phabricator. Differential Revision: D65490202

fduwjj · 2024-11-05T21:59:53Z

This is a auto generated diff trying to fix a internal test failure. (T206766523)

torch/_logging/_registrations.py

…h#139804) Summary: This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T206766523: - The agent searched for and edited the files it deemed relevant for fixing the tests - After generating the patch, the broken test(s) were rerun to verify they now pass - Regression tests were also run to verify CI still passes --- **If this diff is the correct fix for T206766523, please accept the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!* **If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed. --- *P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.* Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//inference_enablement/model_processing/tests:ien_publish_in_trainer_tests -- --exact 'inference_enablement/model_processing/tests:ien_publish_in_trainer_tests - test_sp_in_trainer_publish (inference_enablement.model_processing.tests.ien_publish_in_trainer_tests.IENPublishInTrainerTests)' ``` https://www.internalfb.com/intern/testinfra/testrun/10977524148369514 Differential Revision: D65490202

facebook-github-bot · 2024-11-05T22:31:32Z

This pull request was exported from Phabricator. Differential Revision: D65490202

XilunWu

we can land if internal testing is green.

…h#139804) Summary: This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T206766523: - The agent searched for and edited the files it deemed relevant for fixing the tests - After generating the patch, the broken test(s) were rerun to verify they now pass - Regression tests were also run to verify CI still passes --- **If this diff is the correct fix for T206766523, please accept the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!* **If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed. --- *P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.* Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//inference_enablement/model_processing/tests:ien_publish_in_trainer_tests -- --exact 'inference_enablement/model_processing/tests:ien_publish_in_trainer_tests - test_sp_in_trainer_publish (inference_enablement.model_processing.tests.ien_publish_in_trainer_tests.IENPublishInTrainerTests)' ``` https://www.internalfb.com/intern/testinfra/testrun/10977524148369514 Reviewed By: XilunWu Differential Revision: D65490202

facebook-github-bot · 2024-11-05T23:11:13Z

This pull request was exported from Phabricator. Differential Revision: D65490202

ezyang

I don't see why this right. In particular, there are plenty of other artifacts. Why is not_implemented the only one to be reregistered? This can't be the correct fix.

…h#139804) Summary: This diff was created by the [Meta Engineering Agent](https://fb.workplace.com/groups/1205375940786433/permalink/1205378807452813/) to automatically fix the broken tests assigned to you / your team in T206766523: - The agent searched for and edited the files it deemed relevant for fixing the tests - After generating the patch, the broken test(s) were rerun to verify they now pass - Regression tests were also run to verify CI still passes --- **If this diff is the correct fix for T206766523, please accept the diff**. *Note that while we set a high quality bar for the agent publishing these diffs, LLM-powered agents still make mistakes, so your critical review is much appreciated and will help us improve!* **If changes need to be made:** Please commandeer the diff, or comment with the specific changes needed. --- *P.S. If you have broader feedback, please post in the [Meta Engineering Agent - Users group](https://fb.workplace.com/groups/1205375940786433)! We would love to hear from you on improving the agent to better assist you in your daily work.* Test Plan: ``` buck2 test 'fbcode//mode/opt' fbcode//inference_enablement/model_processing/tests:ien_publish_in_trainer_tests -- --exact 'inference_enablement/model_processing/tests:ien_publish_in_trainer_tests - test_sp_in_trainer_publish (inference_enablement.model_processing.tests.ien_publish_in_trainer_tests.IENPublishInTrainerTests)' ``` https://www.internalfb.com/intern/testinfra/testrun/10977524148369514 Differential Revision: D65490202

facebook-github-bot · 2024-11-07T23:27:05Z

This pull request was exported from Phabricator. Differential Revision: D65490202

facebook-github-bot · 2024-11-08T05:50:24Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2024-11-08T05:51:57Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

facebook-github-bot · 2024-11-08T21:22:46Z

This pull request has been reverted by 411203e. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

This PR is trying to reland #139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: #140169 Approved by: https://github.com/wz337

This PR is trying to reland #139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: #140169 Approved by: https://github.com/wz337, https://github.com/kwen2501

…h#139804) Summary: This is trying to fix a regression caused by pytorch#139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Reviewed By: fduwjj Differential Revision: D65490202 Pull Request resolved: pytorch#139804 Approved by: https://github.com/XilunWu

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337

…h#139804) Summary: This is trying to fix a regression caused by pytorch#139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Reviewed By: fduwjj Differential Revision: D65490202 Pull Request resolved: pytorch#139804 Approved by: https://github.com/XilunWu

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337, https://github.com/kwen2501

…h#139804) Summary: This is trying to fix a regression caused by pytorch#139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Reviewed By: fduwjj Differential Revision: D65490202 Pull Request resolved: pytorch#139804 Approved by: https://github.com/XilunWu

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337, https://github.com/kwen2501

…h#139804) Summary: This is trying to fix a regression caused by pytorch#139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Reviewed By: fduwjj Differential Revision: D65490202 Pull Request resolved: pytorch#139804 Approved by: https://github.com/XilunWu

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337, https://github.com/kwen2501

…h#139804) Summary: This is trying to fix a regression caused by pytorch#139757. We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Reviewed By: fduwjj Differential Revision: D65490202 Pull Request resolved: pytorch#139804 Approved by: https://github.com/XilunWu

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337

) This PR is trying to reland pytorch#139804 We now don't want to log args and kwargs directly because if they contain tensor or tensor subclass it would take lots of time in conversion to string or even not supported. Pull Request resolved: pytorch#140169 Approved by: https://github.com/wz337, https://github.com/kwen2501

facebook-github-bot added the fb-exported label Nov 5, 2024

fduwjj added the topic: not user facing topic category label Nov 5, 2024

fduwjj force-pushed the export-D65490202 branch from 2516683 to 1c8a6b9 Compare November 5, 2024 21:59

fduwjj requested review from Chillee, ezyang and oulgen November 5, 2024 21:59

fduwjj added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2024

XilunWu reviewed Nov 5, 2024

View reviewed changes

torch/_logging/_registrations.py Outdated Show resolved Hide resolved

fduwjj force-pushed the export-D65490202 branch from 1c8a6b9 to bee32ea Compare November 5, 2024 22:31

fduwjj requested a review from XilunWu November 5, 2024 22:32

XilunWu approved these changes Nov 5, 2024

View reviewed changes

fduwjj force-pushed the export-D65490202 branch from bee32ea to d36bc50 Compare November 5, 2024 23:10

ezyang requested changes Nov 5, 2024

View reviewed changes

fduwjj force-pushed the export-D65490202 branch from d36bc50 to a72fc18 Compare November 7, 2024 23:26

pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Nov 7, 2024

pytorchmergebot added the merging label Nov 8, 2024

pytorchmergebot added the Merged label Nov 8, 2024

pytorchmergebot closed this in ba9645f Nov 8, 2024

pytorchmergebot removed the merging label Nov 8, 2024

ZainRizvi mentioned this pull request Nov 8, 2024

TD Heuristic: See if test file name is similar to a file being edited #140167

Closed

fduwjj mentioned this pull request Nov 8, 2024

[c10d][Logging] Remove args and kwargs from c10d logging #140169

Closed

facebook-github-bot added the Reverted label Nov 8, 2024

Fix for T206766523 ("Your diff, D65462767, broke some tests") #139804

Fix for T206766523 ("Your diff, D65462767, broke some tests") #139804

Uh oh!

Conversation

fduwjj commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139804

✅ No Failures

Uh oh!

linux-foundation-easycla bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

fduwjj commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

XilunWu left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 5, 2024

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Nov 7, 2024

Uh oh!

facebook-github-bot commented Nov 8, 2024

Uh oh!

pytorchmergebot commented Nov 8, 2024

Merge started

Uh oh!

facebook-github-bot commented Nov 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fduwjj commented Nov 5, 2024 •

edited

Loading

pytorch-bot bot commented Nov 5, 2024 •

edited

Loading

linux-foundation-easycla bot commented Nov 5, 2024 •

edited

Loading

fduwjj commented Nov 5, 2024 •

edited

Loading