Skip to content

Conversation

@chuanqi129
Copy link
Collaborator

Works for #139722 and #114850

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139775

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures

As of commit 8aaf194 with merge base e2e67a0 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 5, 2024
@chuanqi129 chuanqi129 added the ciflow/xpu Run XPU CI tasks label Nov 5, 2024
@chuanqi129 chuanqi129 force-pushed the xpu_version_upgrade branch 2 times, most recently from 4066f82 to 0d81fe9 Compare November 10, 2024 10:05
@chuanqi129 chuanqi129 changed the title [CI] Upgrade XPU support packages version to 2025.0 for linux CI [CI] Upgrade XPU support packages version to 2025.0 Nov 11, 2024
@chuanqi129 chuanqi129 force-pushed the xpu_version_upgrade branch 3 times, most recently from bb7b93d to 7071809 Compare November 12, 2024 02:58
@icfaust
Copy link

icfaust commented Nov 12, 2024

Sorry if this is a dumb question: will this PR cause XPU nightly wheels to use the 2025.0 compiler?

@chuanqi129
Copy link
Collaborator Author

Sorry if this is a dumb question: will this PR cause XPU nightly wheels to use the 2025.0 compiler?

Hi @icfaust, this PR is dedicate for CI upgrade. And the CD/nightly upgrade PR is WIP, Linux part can refer #140373

@chuanqi129 chuanqi129 force-pushed the xpu_version_upgrade branch 2 times, most recently from c8329e2 to bcffe61 Compare November 14, 2024 07:44
@chuanqi129 chuanqi129 requested a review from atalman November 14, 2024 16:13
@chuanqi129 chuanqi129 marked this pull request as ready for review November 15, 2024 11:02
@chuanqi129 chuanqi129 requested review from a team and jeffdaily as code owners November 15, 2024 11:02
@chuanqi129 chuanqi129 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuanqi129 lgtm. Please add details about two CI xpu errors we see:
inductor/test_inductor_freezing.py::FreezingGpuTests::test_mm_concat_xpu
and
test_xpu.py::TestXpuXPU::test_generic_stream_event_xpu

@chuanqi129
Copy link
Collaborator Author

chuanqi129 commented Nov 15, 2024

Thanks @atalman.

  1. inductor/test_inductor_freezing.py::FreezingGpuTests::test_mm_concat_xpu tracked in [Break XPU][Inductor] Wrong device assignment in addmm_patterns_init() #140917 and will be fixed by [Inductor XPU] Fix wrong device check before skip concat linear. #140916
  2. test_xpu.py::TestXpuXPU::test_generic_stream_event_xpu is new case for 2025.0 which added by Enable XPUEvent elapsed_time function #134666. Tracked in issue [XPU] test_xpu.py::TestXpuXPU::test_generic_stream_event_xpu crashed with XPU support package 2025.0 #140814 and will be fixed by Support torch.Event elapsed_time method on XPU #140865

@EikanWang
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: xpu / linux-jammy-xpu-2025_0-py3.9 / test (default, 1, 4, linux.idc.xpu), xpu / linux-jammy-xpu-2025_0-py3.9 / test (default, 4, 4, linux.idc.xpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged open source topic: not user facing topic category

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants