Skip to content

Fix docs for logcumsumexp formula #139768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidberard98 wants to merge 1 commit into from
Closed

Fix docs for logcumsumexp formula #139768

davidberard98 wants to merge 1 commit into from

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Nov 5, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

The previous formula was wrong and reused some indexing variables.

@davidberard98
Fix docs for logcumsumexp formula
dd6eec3 
The previous formula was wrong and reused some indexing variables.

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Nov 5, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139768

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dd6eec3 with merge base f551d90 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98 added a commit that referenced this pull request Nov 5, 2024
@davidberard98
Fix docs for logcumsumexp formula
8490457 
The previous formula was wrong and reused some indexing variables.

ghstack-source-id: a9e7f0b
Pull Request resolved: #139768
@davidberard98 davidberard98 added the topic: docs topic category label Nov 5, 2024
janeyx99
janeyx99 approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct

thanks

@davidberard98
Copy link
Contributor Author

davidberard98 commented Nov 5, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 5, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 5, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@davidberard98
Fix docs for logcumsumexp formula (pytorch#139768)
994f4ac 
The previous formula was wrong and reused some indexing variables.
Pull Request resolved: pytorch#139768
Approved by: https://github.com/janeyx99
@github-actions github-actions bot deleted the gh/davidberard98/346/head branch December 6, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@SamGinzburg SamGinzburg Awaiting requested review from SamGinzburg

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidberard98 @pytorchmergebot @janeyx99