-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Environment Variable][5/N] Use thread-safe getenv functions #139762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139762
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 711fc90 with merge base 4d5cc1b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs" |
2 similar comments
|
@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs" |
|
@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…#139762)" This reverts commit 43f0fe6. Reverted #139762 on behalf of https://github.com/malfet due to One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs ([comment](#139762 (comment)))
|
@cyyever your PR has been successfully reverted. |
|
This one looks OK, all value() accesses guarded |
…140594) Reland of #139762 with no bug found. Pull Request resolved: #140594 Approved by: https://github.com/ezyang
…h#139762) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#139762 Approved by: https://github.com/ezyang
…pytorch#139762)" This reverts commit 43f0fe6. Reverted pytorch#139762 on behalf of https://github.com/malfet due to One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs ([comment](pytorch#139762 (comment)))
…ytorch#140594) Reland of pytorch#139762 with no bug found. Pull Request resolved: pytorch#140594 Approved by: https://github.com/ezyang
Fixes #ISSUE_NUMBER