Skip to content

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Nov 5, 2024

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139762

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 711fc90 with merge base 4d5cc1b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: linalg_frontend release notes category label Nov 5, 2024
@cyyever cyyever requested a review from ezyang November 8, 2024 01:03
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 8, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ezyang
Copy link
Contributor

ezyang commented Nov 13, 2024

@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs"

2 similar comments
@ezyang
Copy link
Contributor

ezyang commented Nov 13, 2024

@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs"

@malfet
Copy link
Contributor

malfet commented Nov 13, 2024

@pytorchbot revert -c nosignal -m "One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Nov 13, 2024
…#139762)"

This reverts commit 43f0fe6.

Reverted #139762 on behalf of https://github.com/malfet due to One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs ([comment](#139762 (comment)))
@pytorchmergebot
Copy link
Collaborator

@cyyever your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 13, 2024
@ezyang
Copy link
Contributor

ezyang commented Nov 13, 2024

This one looks OK, all value() accesses guarded

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…pytorch#139762)"

This reverts commit 43f0fe6.

Reverted pytorch#139762 on behalf of https://github.com/malfet due to One of these diffs had incorrect downstream optional handling, we must reaudit all of these diffs ([comment](pytorch#139762 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: linalg_frontend release notes category Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants