[ROCm] re-enable flex attention UTs #139632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jataylo
added
rocm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139632
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1f15726 with merge base 419a7e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jataylo
added
the
keep-going
Collaborator
Author
|
Rebasing to run CI again but with keep-going label. |
Collaborator
Author
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Collaborator
Collaborator
Author
|
Opened issue for failure #139754 will skip UT for now and merge this. |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
pytorch#136792 accidentally disabled flex attention UTs on ROCm. Re-enabling. Pull Request resolved: pytorch#139632 Approved by: https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#136792 accidentally disabled flex attention UTs on ROCm. Re-enabling.
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @hongxiayang @naromero77amd