-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Fix cuda Manylinux 2_28 docker images PATH setting #139631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139631
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ebfabf4 with merge base 87404b6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just curious why this is not the part of common/install_cuda.sh
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Enabling Manywheel builds here: pytorch#138732 During the build I observe the failure with cuda jobs: ``` -- Compiler does not support SVE extension. Will not build perfkernels. -- Found CUDA: /usr/local/cuda (found version "11.8") -- The CUDA compiler identification is unknown CMake Error at cmake/public/cuda.cmake:47 (enable_language): No CMAKE_CUDA_COMPILER could be found. Tell CMake where to find the compiler by setting either the environment variable "CUDACXX" or the CMake cache entry CMAKE_CUDA_COMPILER to the full path to the compiler, or to the compiler name if it is in the PATH. Call Stack (most recent call first): cmake/Dependencies.cmake:44 (include) CMakeLists.txt:851 (include) ``` While correct sequence suppose to be: ``` -- Found CUDA: /usr/local/cuda (found version "11.8") -- The CUDA compiler identification is NVIDIA 11.8.89 -- Detecting CUDA compiler ABI info -- Detecting CUDA compiler ABI info - done -- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped -- Detecting CUDA compile features -- Detecting CUDA compile features - done -- Found CUDAToolkit: /usr/local/cuda/include (found version "11.8.89") ``` Issue found to be missing PATH setting in 2_28 Docker file. This section exist in CentOS Docker file here: https://github.com/pytorch/pytorch/blob/main/.ci/docker/manywheel/Dockerfile#L174-L175 (Please Note these Docker images are not used yet. The pytorch#138732 should enable using these images) Pull Request resolved: pytorch#139631 Approved by: https://github.com/malfet, https://github.com/huydhn
Enabling Manywheel builds here: #138732
During the build I observe the failure with cuda jobs:
While correct sequence suppose to be:
Issue found to be missing PATH setting in 2_28 Docker file. This section exist in CentOS Docker file here:
https://github.com/pytorch/pytorch/blob/main/.ci/docker/manywheel/Dockerfile#L174-L175
(Please Note these Docker images are not used yet. The #138732 should enable using these images)