[AOTI][reland] Switch OSS dashboard to use aoti_compile_and_package #139597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Reland #139154 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139597
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ec33e2c with merge base 5d07651 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
desertfire
added
topic: not user facing
angelayi
reviewed
Nov 4, 2024
| for o_file in [ | ||
| output_o, | ||
| consts_o, | ||
| os.path.splitext(consts_o)[0] + ".S", |
Contributor
Author
There was a problem hiding this comment.
copied from the weights emitting logic from the macos path. Either .s or .S should be fine for weights emitting purpose.
angelayi
approved these changes
Nov 4, 2024
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
facebook-github-bot
pushed a commit
to pytorch/benchmark
that referenced
this pull request
Nov 5, 2024
Summary: Reland pytorch/pytorch#139154 X-link: pytorch/pytorch#139597 Approved by: https://github.com/angelayi Reviewed By: ZainRizvi Differential Revision: D65455707 Pulled By: desertfire fbshipit-source-id: 691882e606754fc04cb826a14bdfe94cb465ece8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: Reland #139154
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @chauhang @aakhundov