Skip to content

add special case for __round__ constant variables #139583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 24 commits into from
Closed

add special case for __round__ constant variables #139583

bobrenjc93 wants to merge 24 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Nov 3, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64 when specialize_float=False

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

This was referenced Nov 3, 2024
Closed
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139583

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5e80e0b with merge base e6ff07f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bobrenjc93 bobrenjc93 mentioned this pull request Nov 3, 2024
Closed
@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 3, 2024
This was referenced Nov 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@bobrenjc93 bobrenjc93 added topic: not user facing topic category and removed fx labels Nov 3, 2024
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
0c675da 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
f838a69 
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
00e6786 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
b50968d 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 4, 2024
Closed
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
4ec35af 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
e448b50 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
a3c3fe1 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
ezyang
ezyang reviewed Nov 4, 2024
View reviewed changes
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
4114fe6 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
c95836c 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
c7cac1f 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
88260ee 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Nov 6, 2024
@bobrenjc93
Add one more meta val pass in tensorify
05ea16a 
ghstack-source-id: e4f16b7
Pull Request resolved: #139583
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
df177f3 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 mentioned this pull request Nov 6, 2024
Closed
This was referenced Nov 6, 2024
Closed
Closed
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
b72dd51 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
7573ba2 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
260b92f 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
8af8769 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Update on "Add one more meta val pass in tensorify"
4347c56 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93 bobrenjc93 changed the title Add one more meta val pass in tensorify add special case for __round__ constant variables Nov 8, 2024
@bobrenjc93 bobrenjc93 added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2024
@bobrenjc93 bobrenjc93 marked this pull request as ready for review November 8, 2024 04:36
@bobrenjc93 bobrenjc93 requested a review from ezyang November 8, 2024 04:36
@bobrenjc93
Update on "add special case for __round__ constant variables"
5e80e0b 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Nov 9, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 9, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@bobrenjc93
add special case for __round__ constant variables (pytorch#139583)
c107733 
Fixes `PYTORCH_TEST_WITH_INDUCTOR=1 tlp python test/test_torch.py TestTorchDeviceTypeCUDA.test_cauchy_cuda_float64` when specialize_float=False

Pull Request resolved: pytorch#139583
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#139569, pytorch#139457, pytorch#139568, pytorch#139572, pytorch#139846, pytorch#139454, pytorch#139896, pytorch#139935, pytorch#139587
@github-actions github-actions bot deleted the gh/bobrenjc93/109/head branch December 10, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: fx release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobrenjc93 @pytorchmergebot @ezyang @facebook-github-bot