Skip to content

Fix S390 builds #139491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

Fix S390 builds #139491

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 1, 2024

Caused by #137918 By guarding all cpuinfo use with !defined(__s390x__ ) && !defined(__powerpc__)

@malfet
Fix S390 builds
0da1090 
Caused by #137918
By guarding all cpuinfo use with `!defined(__s390x__ ) && !defined(__powerpc__)`
@malfet malfet added topic: not user facing topic category ciflow/s390 s390x-related CI jobs labels Nov 1, 2024
@malfet malfet requested a review from swolchok November 1, 2024 17:17
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139491

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0da1090 with merge base 7d081ca (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor Author

malfet commented Nov 1, 2024

@pytorchbot merge -f "This looks like a move in the right direction"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 1, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@malfet @rahulsingh-intel
Fix S390 builds (pytorch#139491)
c963fd8 
Caused by pytorch#137918 By guarding all cpuinfo use with `!defined(__s390x__ ) && !defined(__powerpc__)`

Pull Request resolved: pytorch#139491
Approved by: https://github.com/huydhn, https://github.com/Skylion007
@github-actions github-actions bot deleted the malfet-patch-29 branch December 2, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

ciflow/s390 s390x-related CI jobs Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @pytorchmergebot @huydhn @Skylion007