Add torch.version.xpu #139466
Closed
Add torch.version.xpu #139466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139466
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2888994 with merge base dfcf740 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
EikanWang
approved these changes
Nov 5, 2024
ezyang
approved these changes
Nov 5, 2024
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: Approvers from one of the following sets are needed:
|
guangyey
commented
Nov 7, 2024
| self.assertTrue(len(torch.version.xpu) == 8) | ||
| compiler_version = int(torch.version.xpu) | ||
| self.assertTrue(compiler_version >= 20230000) | ||
| if IS_LINUX: |
Collaborator
Author
There was a problem hiding this comment.
According to @atalman 's comments, I supplemented this UT to validate the build flow as we expected.
atalman
approved these changes
Nov 7, 2024
Contributor
atalman
left a comment
atalman
left a comment
There was a problem hiding this comment.
Lgtm. Please fix lint before merging
Collaborator
Author
Thanks @atalman, lint is fixed. |
malfet
approved these changes
Nov 8, 2024
Collaborator
Author
|
The UT failure is unrelated to this PR, refer to #140095 |
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Ryo-not-rio
pushed a commit
to Ryo-not-rio/pytorch
that referenced
this pull request
Dec 2, 2024
# Motivation We add a new attribute `torch.version.xpu` to facilitate the problem diagnosing and version control. # Additional Context It is aligned with `torch.version.cuda` and `torch.version.hip`. Pull Request resolved: pytorch#139466 Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman, https://github.com/malfet ghstack dependencies: pytorch#139258
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Motivation We add a new attribute `torch.version.xpu` to facilitate the problem diagnosing and version control. # Additional Context It is aligned with `torch.version.cuda` and `torch.version.hip`. Pull Request resolved: pytorch#139466 Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman, https://github.com/malfet ghstack dependencies: pytorch#139258
fmo-mt
pushed a commit
to fmo-mt/pytorch
that referenced
this pull request
Dec 11, 2024
# Motivation We add a new attribute `torch.version.xpu` to facilitate the problem diagnosing and version control. # Additional Context It is aligned with `torch.version.cuda` and `torch.version.hip`. Pull Request resolved: pytorch#139466 Approved by: https://github.com/EikanWang, https://github.com/ezyang, https://github.com/atalman, https://github.com/malfet ghstack dependencies: pytorch#139258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
We add a new attribute
torch.version.xputo facilitate the problem diagnosing and version control.Additional Context
It is aligned with
torch.version.cudaandtorch.version.hip.