re-enable dilated convolutions on Kepler #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
reviewed
Apr 28, 2017
| cudaDeviceProp* prop = THCState_getCurrentDeviceProperties(state); | ||
| return CUDNN_VERSION >= 6000 && prop->major >= 5 && !transposed; | ||
| return ((CUDNN_VERSION >=6021) || (CUDNN_VERSION >= 6000 && prop->major >= 5 )) && !transposed; | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Collaborator
Author
|
No, it still fails if I remove !transposed (in fact, it fails for 1d, 2d, and 3d whereas before it used to fail for 2d and 3d because 1d dilation parameters were not passed). I think there is something wrong with the parameters passed to transposed dilated cudnn case. |
Contributor
|
thanks! |
Jiaming-Liu
pushed a commit
to Jiaming-Liu/pytorch
that referenced
this pull request
May 18, 2017
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Jan 26, 2022
akashveramd
pushed a commit
to akashveramd/pytorch
that referenced
this pull request
Apr 9, 2025
…_softmax_rank4 failure (pytorch#1394)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.