[dynamo] Add is_mutable() and is_immutable() methods to VariableTracker
#139341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139341
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4ccd9c8 with merge base b82a51b ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
StrongerXi
added a commit
that referenced
this pull request
Oct 30, 2024
…Tracker`
This patch adds 2 simple methods `VariableTracker.is_mutable()` and
`VariableTracker.is_immutable()`, which helps clarify intention. For
instance, rather than writing
```python
if var.mutation_type:
...
```
After this patch one can write
```python
if var.is_mutable():
...
```
This patch also simplifies `mutation_type` propagation in some
`ListVariable` methods.
ghstack-source-id: d8954a3
Pull Request resolved: #139341
StrongerXi
added a commit
that referenced
this pull request
Oct 31, 2024
…Tracker`
This patch adds 2 simple methods `VariableTracker.is_mutable()` and
`VariableTracker.is_immutable()`, which helps clarify intention. For
instance, rather than writing
```python
if var.mutation_type:
...
```
After this patch one can write
```python
if var.is_mutable():
...
```
This patch also simplifies `mutation_type` propagation in some
`ListVariable` methods.
ghstack-source-id: 289e2a9
Pull Request resolved: #139341
mlazos
approved these changes
Nov 4, 2024
anijain2305
reviewed
Nov 4, 2024
torch/_dynamo/variables/base.py
Outdated
|
|
||
| def is_mutable(self): | ||
| """Whether Dynamo allows mutation on this variable.""" | ||
| return self.mutation_type |
Contributor
There was a problem hiding this comment.
Nit - return self.mutation_type is not None?
Contributor
Author
There was a problem hiding this comment.
Good call, updating.
anijain2305
approved these changes
Nov 4, 2024
StrongerXi
added a commit
that referenced
this pull request
Nov 5, 2024
…Tracker`
This patch adds 2 simple methods `VariableTracker.is_mutable()` and
`VariableTracker.is_immutable()`, which helps clarify intention. For
instance, rather than writing
```python
if var.mutation_type:
...
```
After this patch one can write
```python
if var.is_mutable():
...
```
This patch also simplifies `mutation_type` propagation in some
`ListVariable` methods.
ghstack-source-id: d252122
Pull Request resolved: #139341
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…Tracker` (pytorch#139341) This patch adds 2 simple methods `VariableTracker.is_mutable()` and `VariableTracker.is_immutable()`, which helps clarify intention. For instance, rather than writing ```python if var.mutation_type: ... ``` After this patch one can write ```python if var.is_mutable(): ... ``` This patch also simplifies `mutation_type` propagation in some `ListVariable` methods. Pull Request resolved: pytorch#139341 Approved by: https://github.com/mlazos, https://github.com/anijain2305 ghstack dependencies: pytorch#139339, pytorch#139340
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
is_mutable()andis_immutable()methods toVariableTracker#139341MutationTypeclasses intovariables/base.py#139340mutable_localand add documentation #139339This patch adds 2 simple methods
VariableTracker.is_mutable()andVariableTracker.is_immutable(), which helps clarify intention. Forinstance, rather than writing
After this patch one can write
This patch also simplifies
mutation_typepropagation in someListVariablemethods.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames