Move close_nonexistent_disable_issues.py queries to ClickHouse #139296
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139296
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 10ca244 with merge base 9bbe4a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
clee2000
temporarily deployed
to
rockset-read-only
GitHub Actions
Inactive
clee2000
temporarily deployed
to
rockset-read-only
GitHub Actions
Inactive
clee2000
temporarily deployed
to
rockset-read-only
GitHub Actions
Inactive
clee2000
temporarily deployed
to
rockset-read-only
GitHub Actions
Inactive
clee2000
had a problem deploying
to
rockset-read-only
GitHub Actions
Error
clee2000
changed the title
| push.head_commit.id as sha | ||
| FROM | ||
| commons.push | ||
| -- Not bothering with final here |
There was a problem hiding this comment.
I learn from @ZainRizvi that the use (or abuse) of having final on the query could be the reason why some of my queries run OOM. I guess I need to go back and double check some of them
| TEST_EXISTS_QUERY = """ | ||
| select | ||
| count(*) as c | ||
| name |
There was a problem hiding this comment.
Nit: Why not just count it here like the original query? (I couldn't find what is that name is used for, so I guess it's not needed)
There was a problem hiding this comment.
It's faster to just find one than to find all of them
|
@pytorchbot merge -f "no trunk needed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ch#139296) Example run: https://github.com/pytorch/pytorch/actions/runs/11601996563/job/32305991204?pr=139296 (commented out the part that actually closes issues but the queries run) Pull Request resolved: pytorch#139296 Approved by: https://github.com/huydhn
3 participants
Example run: https://github.com/pytorch/pytorch/actions/runs/11601996563/job/32305991204?pr=139296 (commented out the part that actually closes issues but the queries run)