Skip to content

[fx] split_module subgraph should always have an output node #139275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshitij12345 wants to merge 4 commits into from
Closed

[fx] split_module subgraph should always have an output node #139275

kshitij12345 wants to merge 4 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Oct 30, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139275

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a6dee98 with merge base 9bbe4a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 30, 2024
@kshitij12345 kshitij12345 requested a review from ezyang October 30, 2024 10:19
@ezyang
Copy link
Contributor

ezyang commented Oct 31, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kshitij12345 kshitij12345 deleted the fix-split-module-no-output branch October 31, 2024 07:58
@kiya00 kiya00 mentioned this pull request Oct 31, 2024
Closed
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@kshitij12345 @rahulsingh-intel
[fx] split_module subgraph should always have an output node (pytorch…
a6c2670 
…#139275)

Fixes pytorch#138207

Pull Request resolved: pytorch#139275
Approved by: https://github.com/ezyang
@kiya00 kiya00 mentioned this pull request Nov 14, 2024
Merged
4 tasks
@kiya00 kiya00 mentioned this pull request Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged open source release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fx] Unable to deepcopy a graph produced by fx's split_module

5 participants

@kshitij12345 @ezyang @pytorchmergebot @facebook-github-bot @pytorchbot