Skip to content

Unbreak fp16 dot issues caused by #137917 #139262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swolchok wants to merge 1 commit into from
Closed

Unbreak fp16 dot issues caused by #137917 #139262

swolchok wants to merge 1 commit into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Oct 30, 2024 •
edited by pytorch-bot bot
Loading

See comment for explanation. In short, doing the fixup in float.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@swolchok
Unbreak fp16 dot issues caused by #137917
c37e9f2 
See comment for explanation. In short, doing the fixup in float.
@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 30, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139262

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c37e9f2 with merge base 4e5f9af (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn
huydhn approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@swolchok
Copy link
Contributor Author

swolchok commented Oct 30, 2024

I ran the following to verify per HUD failures:

env PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=9 python test/inductor/test_torchinductor_opinfo.py TestInductorOpInfoCPU.test_comprehensive_matmul_cpu_float16
env PYTORCH_OPINFO_SAMPLE_INPUT_INDEX=2 python test/inductor/test_torchinductor_opinfo.py TestInductorOpInfoCPU.test_comprehensive_nn_functional_linear_cpu_float16

@swolchok
Copy link
Contributor Author

swolchok commented Oct 30, 2024

@pytorchbot merge -f "unbreaking main"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@swolchok @rahulsingh-intel
Unbreak fp16 dot issues caused by pytorch#137917 (pytorch#139262)
c9d0f8b 
See comment for explanation. In short, doing the fixup in float.

Pull Request resolved: pytorch#139262
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the unbreak-fp16-dot branch November 30, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @pytorchmergebot @huydhn