Skip to content

Add conjugate method on SymFloat #139249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bobrenjc93 wants to merge 3 commits into from
Closed

Add conjugate method on SymFloat #139249

bobrenjc93 wants to merge 3 commits into from

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Oct 30, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes python test/dynamo/test_dynamic_shapes.py DynamicShapesFunctionTests.test_number_method_method_conjugate_num_type4_dynamic_shapes

when we turn off specialize float on eager: #138915

This was referenced Oct 30, 2024
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139249

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit bb6203d with merge base ad637a4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

bobrenjc93 added a commit that referenced this pull request Oct 30, 2024
@bobrenjc93
Add conjugate method on SymFloat
2e140c1 
ghstack-source-id: c5bcdf9
Pull Request resolved: #139249
@bobrenjc93 bobrenjc93 requested a review from ezyang October 30, 2024 02:45
@bobrenjc93 bobrenjc93 marked this pull request as ready for review October 30, 2024 02:45
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Oct 30, 2024
@bobrenjc93 bobrenjc93 mentioned this pull request Oct 30, 2024
Closed
ezyang
ezyang approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swing this out on its own i guess

@bobrenjc93
Update on "Add conjugate method on SymFloat"
65fa208 
Fixes python test/dynamo/test_dynamic_shapes.py DynamicShapesFunctionTests.test_number_method_method_conjugate_num_type4_dynamic_shapes

when we turn off specialize float on eager: #138915


[ghstack-poisoned]
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 30, 2024

@pytorchbot merge -f "ci failures unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 30, 2024

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Oct 31, 2024

@pytorchbot revert -m 'Sorry for reverting your change, but the doc build failure is legit' -c ignoredsignals

The error about missing public doc is at the bottom of the log https://github.com/pytorch/pytorch/actions/runs/11603262024/job/32310379311#step:11:1319

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: argument -c/--classification: invalid choice: 'ignoredsignals' (choose from 'nosignal', 'ignoredsignal', 'landrace', 'weird', 'ghfirst')

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

@huydhn
Copy link
Contributor

huydhn commented Oct 31, 2024

@pytorchbot revert -m 'Sorry for reverting your change, but the doc build failure is legit' -c ignoredsignal

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

@bobrenjc93 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 31, 2024
@pytorchmergebot
Revert "Add conjugate method on SymFloat (#139249)"
42d790b 
This reverts commit bcf8a01.

Reverted #139249 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but the doc build failure is legit ([comment](#139249 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 31, 2024
@bobrenjc93
Update on "Add conjugate method on SymFloat"
bb6203d 
Fixes python test/dynamo/test_dynamic_shapes.py DynamicShapesFunctionTests.test_number_method_method_conjugate_num_type4_dynamic_shapes

when we turn off specialize float on eager: #138915


[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Oct 31, 2024
@bobrenjc93
Add conjugate method on SymFloat
d947db2 
ghstack-source-id: 0df5622
Pull Request resolved: #139249
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Oct 31, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2024
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 31, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@bobrenjc93 @rahulsingh-intel
Add conjugate method on SymFloat (pytorch#139249)
3b9a3a7 
Fixes python test/dynamo/test_dynamic_shapes.py DynamicShapesFunctionTests.test_number_method_method_conjugate_num_type4_dynamic_shapes

when we turn off specialize float on eager: pytorch#138915

Pull Request resolved: pytorch#139249
Approved by: https://github.com/ezyang
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@pytorchmergebot @rahulsingh-intel
Revert "Add conjugate method on SymFloat (pytorch#139249)"
102a471 
This reverts commit bcf8a01.

Reverted pytorch#139249 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but the doc build failure is legit ([comment](pytorch#139249 (comment)))
rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
@bobrenjc93 @rahulsingh-intel
Add conjugate method on SymFloat (pytorch#139249)
4fcfa4e 
Fixes python test/dynamo/test_dynamic_shapes.py DynamicShapesFunctionTests.test_number_method_method_conjugate_num_type4_dynamic_shapes

when we turn off specialize float on eager: pytorch#138915

Pull Request resolved: pytorch#139249
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the gh/bobrenjc93/95/head branch December 1, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobrenjc93 @pytorchmergebot @huydhn @ezyang