Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 29, 2024

To make sure that inductor tracing rules can be used to trace numpy-2.X

To make sure that inductor tracing rules can be used to trace numpy-2.X
@malfet malfet requested a review from a team as a code owner October 29, 2024 16:18
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 29, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139199

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8448d78 with merge base d8f99f3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Oct 29, 2024
@malfet malfet requested a review from desertfire October 29, 2024 16:18
@malfet malfet added the topic: not user facing topic category label Oct 29, 2024
@haifeng-jin
Copy link
Collaborator

haifeng-jin commented Oct 30, 2024

@malfet

Thank you so much for creating the PR!

I see the newly added CI test failed. link
In the log, I saw

  env:
    GIT_DEFAULT_BRANCH: main
    BUILD_ENVIRONMENT: linux-jammy-py3.9-gcc11

I also saw a lot of tests were run instead of the given test_unspec.py.

My understanding is that it is likely that the if [[ "${BUILD_ENVIRONMENT}" == *numpy-2* ]]; then did not catch it since the BUILD_ENVIRONMENT is listed as a different value above.
It goes into the final else to run a lot of tests.

What do you think?

@malfet
Copy link
Contributor Author

malfet commented Nov 20, 2024

Closing in favor of #140586 which fixes the silly typo I've made

@malfet malfet closed this Nov 20, 2024
pytorchmergebot pushed a commit that referenced this pull request Nov 20, 2024
Fixes #107302

This is a clone and fix for #139199.

This PR is a small step for the overall NumPy 2 support.
It adds a new CI job for testing with NumPy 2 with one test file only.
More tests to be fixed and added later in follow-up pull requests.

Pull Request resolved: #140586
Approved by: https://github.com/malfet

Co-authored-by: Nikita Shulga <[email protected]>
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Fixes pytorch#107302

This is a clone and fix for pytorch#139199.

This PR is a small step for the overall NumPy 2 support.
It adds a new CI job for testing with NumPy 2 with one test file only.
More tests to be fixed and added later in follow-up pull requests.

Pull Request resolved: pytorch#140586
Approved by: https://github.com/malfet

Co-authored-by: Nikita Shulga <[email protected]>
@malfet malfet deleted the malfet/add-numpy-2.0-shard branch December 12, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: releng release notes category topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants