Move bf16_gemv_trans to ReducedPrecisionFloatGemvFastPathKernel #139081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnel Following the previous move of fp16_gemv_trans. Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) [ghstack-poisoned]
pytorch-bot
bot
added
the
module: cpu
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139081
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 85dadbd with merge base 419a7e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
This was referenced Oct 28, 2024
Closed
…vFastPathKernel" Following the previous move of fp16_gemv_trans. Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
…vFastPathKernel" Following the previous move of fp16_gemv_trans. Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
…vFastPathKernel" Following the previous move of fp16_gemv_trans. Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
…ernel" Following the previous move of fp16_gemv_trans. Testing: Checked for performance regression with llm_benchmarks' `python benchmarks/benchmark_torch_mm.py llm`, didn't find one Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
…ernel" Following the previous move of fp16_gemv_trans. Testing: Checked for performance regression with llm_benchmarks' `python benchmarks/benchmark_torch_mm.py llm`, didn't find one Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
…ernel" Following the previous move of fp16_gemv_trans. Testing: Checked for performance regression with llm_benchmarks' `python benchmarks/benchmark_torch_mm.py llm`, didn't find one Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64930872 |
Contributor
Author
|
some tests still in progress, but none of them are mps/aarch64 so I'm optimistic and re-requesting review. |
malfet
approved these changes
Nov 8, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 8, 2024
#139208) Very similar to #137917, but for bf16. Differential Revision: [D65155971](https://our.internmc.facebook.com/intern/diff/D65155971/) Pull Request resolved: #139208 Approved by: https://github.com/malfet ghstack dependencies: #139084, #139090, #139558, #139081
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 8, 2024
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) Pull Request resolved: #139220 Approved by: https://github.com/malfet ghstack dependencies: #139084, #139090, #139558, #139081, #139208
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…rch#139081) Following the previous move of fp16_gemv_trans. Testing: Checked for performance regression with llm_benchmarks' `python benchmarks/benchmark_torch_mm.py llm`, didn't find one Differential Revision: [D64930872](https://our.internmc.facebook.com/intern/diff/D64930872/) Pull Request resolved: pytorch#139081 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139084, pytorch#139090, pytorch#139558
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
pytorch#139208) Very similar to pytorch#137917, but for bf16. Differential Revision: [D65155971](https://our.internmc.facebook.com/intern/diff/D65155971/) Pull Request resolved: pytorch#139208 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139084, pytorch#139090, pytorch#139558, pytorch#139081
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) Pull Request resolved: pytorch#139220 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139084, pytorch#139090, pytorch#139558, pytorch#139081, pytorch#139208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Following the previous move of fp16_gemv_trans.
Testing: Checked for performance regression with llm_benchmarks'
python benchmarks/benchmark_torch_mm.py llm, didn't find oneDifferential Revision: D64930872
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10