[Bugfix] UnicodeDecodeError: 'utf-8' codec can't decode byte #139062

Abatom · 2024-10-28T12:27:47Z

When I used PyTorch's profiler to analyze the performance of vLLM, I encountered the following error. This error is similar to #113564. After analysis and troubleshooting, I changed the temporary file from text mode to binary mode, and it no longer reported an error and ran normally.

ERROR 10-28 10:25:50 engine.py:160]   File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 722, in stop 
ERROR 10-28 10:25:50 engine.py:160]     self._transit_action(self.current_action, None) 
ERROR 10-28 10:25:50 engine.py:160]   File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 751, in _transit_action 
ERROR 10-28 10:25:50 engine.py:160]     action() 
ERROR 10-28 10:25:50 engine.py:160]   File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 745, in _trace_ready 
ERROR 10-28 10:25:50 engine.py:160]     self.on_trace_ready(self) 
ERROR 10-28 10:25:50 engine.py:160]   File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 444, in handler_fn 
ERROR 10-28 10:25:50 engine.py:160]     prof.export_chrome_trace(os.path.join(dir_name, file_name)) 
ERROR 10-28 10:25:50 engine.py:160]   File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 220, in export_chrome_trace 
ERROR 10-28 10:25:50 engine.py:160]     fout.writelines(fin) 
ERROR 10-28 10:25:50 engine.py:160]   File "<frozen codecs>", line 322, in decode 
ERROR 10-28 10:25:50 engine.py:160] UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8e in position 5896: invalid start byte

pytorch-bot · 2024-10-28T12:27:50Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139062

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d8432de with merge base b9618c9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla · 2024-10-28T12:27:51Z

The committers listed above are authorized under a signed CLA.

✅ login: Abatom / name: 科英 (d8432de, 30f69af)

ezyang · 2024-10-28T16:48:34Z

I'd like to accept this but I can't tell what the old code was trying to do

Abatom · 2024-10-28T17:07:12Z

I'd like to accept this but I can't tell what the old code was trying to do

Thank you for your reply. What do I need to do?

sraikund16 · 2024-10-28T18:34:06Z

I'd like to accept this but I can't tell what the old code was trying to do

This function is called to create the JSON for perfetto/chrome tracer. If it sees that the user is trying to export to a .gz file, it creates a temporary file, exports the data to it using the autograd export_chrome_trace function, and then does compressed writes to the desired .gz file.

I think in this case it makes the most sense to write in binary mode instead of text

torch/profiler/profiler.py

ezyang · 2024-10-29T02:44:00Z

@pytorchbot merge

pytorchmergebot · 2024-10-29T02:46:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-29T03:07:35Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Lint / lintrunner-noclang / linux-job

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

ezyang · 2024-10-29T14:33:56Z

@pytorchbot merge -r

pytorchmergebot · 2024-10-29T14:36:27Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-10-29T14:36:31Z

Successfully rebased profiler onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout profiler && git pull --rebase)

pytorchmergebot · 2024-10-29T14:37:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…#139062) Fixes pytorch#113564 When I used PyTorch's profiler to analyze the performance of vLLM, I encountered the following error. This error is similar to pytorch#113564. After analysis and troubleshooting, I changed the temporary file from text mode to binary mode, and it no longer reported an error and ran normally. ```bash ERROR 10-28 10:25:50 engine.py:160] File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 722, in stop ERROR 10-28 10:25:50 engine.py:160] self._transit_action(self.current_action, None) ERROR 10-28 10:25:50 engine.py:160] File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 751, in _transit_action ERROR 10-28 10:25:50 engine.py:160] action() ERROR 10-28 10:25:50 engine.py:160] File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 745, in _trace_ready ERROR 10-28 10:25:50 engine.py:160] self.on_trace_ready(self) ERROR 10-28 10:25:50 engine.py:160] File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 444, in handler_fn ERROR 10-28 10:25:50 engine.py:160] prof.export_chrome_trace(os.path.join(dir_name, file_name)) ERROR 10-28 10:25:50 engine.py:160] File "/usr/local/lib/python3.12/dist-packages/torch/profiler/profiler.py", line 220, in export_chrome_trace ERROR 10-28 10:25:50 engine.py:160] fout.writelines(fin) ERROR 10-28 10:25:50 engine.py:160] File "<frozen codecs>", line 322, in decode ERROR 10-28 10:25:50 engine.py:160] UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8e in position 5896: invalid start byte ``` Pull Request resolved: pytorch#139062 Approved by: https://github.com/ezyang

tomasruizt · 2025-01-19T14:25:32Z

thanks for fixing this bug! @Abatom. Do you know when it will be released?

Abatom · 2025-01-23T11:02:43Z

thanks for fixing this bug! @Abatom. Do you know when it will be released?

sorry I don't know

hchau630 · 2025-06-30T00:14:54Z

Also encountering this bug, will this fix be included in a release soon?

Abatom requested a review from sraikund16 as a code owner October 28, 2024 12:27

pytorchbot added the open source label Oct 28, 2024

ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 28, 2024

sraikund16 reviewed Oct 28, 2024

View reviewed changes

torch/profiler/profiler.py Outdated Show resolved Hide resolved

Abatom requested a review from sraikund16 October 29, 2024 01:38

ezyang approved these changes Oct 29, 2024

View reviewed changes

ezyang added release notes: profiler release notes category topic: bug fixes topic category labels Oct 29, 2024

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 29, 2024

pytorchmergebot added the merging label Oct 29, 2024

pytorchmergebot removed the merging label Oct 29, 2024

Abatom requested a review from ezyang October 29, 2024 05:46

Abatom added 2 commits October 29, 2024 14:36

fix bug

30f69af

format

d8432de

pytorchmergebot force-pushed the profiler branch from 482a966 to d8432de Compare October 29, 2024 14:36

pytorchmergebot added the merging label Oct 29, 2024

pytorchmergebot added the Merged label Oct 29, 2024

pytorchmergebot closed this in c98c88a Oct 29, 2024

pytorchmergebot removed the merging label Oct 29, 2024

[Bugfix] UnicodeDecodeError: 'utf-8' codec can't decode byte #139062

[Bugfix] UnicodeDecodeError: 'utf-8' codec can't decode byte #139062

Uh oh!

Conversation

Abatom commented Oct 28, 2024

Uh oh!

pytorch-bot bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139062

✅ No Failures

Uh oh!

linux-foundation-easycla bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang commented Oct 28, 2024

Uh oh!

Abatom commented Oct 28, 2024

Uh oh!

sraikund16 commented Oct 28, 2024

Uh oh!

Uh oh!

ezyang commented Oct 29, 2024

Uh oh!

pytorchmergebot commented Oct 29, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 29, 2024

Merge failed

Uh oh!

ezyang commented Oct 29, 2024

Uh oh!

pytorchmergebot commented Oct 29, 2024

Uh oh!

pytorchmergebot commented Oct 29, 2024

Uh oh!

pytorchmergebot commented Oct 29, 2024

Merge started

Uh oh!

tomasruizt commented Jan 19, 2025

Uh oh!

Abatom commented Jan 23, 2025

Uh oh!

hchau630 commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pytorch-bot bot commented Oct 28, 2024 •

edited

Loading

linux-foundation-easycla bot commented Oct 28, 2024 •

edited

Loading