[AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. #139026

etaf · 2024-10-28T01:23:03Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

[ghstack-poisoned]

pytorch-bot · 2024-10-28T01:23:07Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139026

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

GLIBC not found in Nova workflows

✅ No Failures

As of commit a7ca4d9 with merge base 3ce75e7 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

etaf · 2024-10-28T03:09:18Z

This PR depends on torch-xpu-ops PR intel/torch-xpu-ops#1021, I will update the toch-xpu-ops commit pin after torch-xpu-ops PR merged.

[ghstack-poisoned]

EikanWang · 2024-10-30T04:16:24Z

@etaf , pls. feel free to reach out to me if the PR is ready for review.

[ghstack-poisoned]

etaf · 2024-11-14T03:47:33Z

@EikanWang @desertfire this PR originally update torch-xpu-ops and remove the previous workarounds, but the torch-xpu-ops update have been done at PR #140277. So this PR is ready to land, please have a review, thanks.

etaf · 2024-11-14T14:55:17Z

@pytorchbot merge

pytorchmergebot · 2024-11-14T14:57:02Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…c_shim_xpu layer with out-of-tree ATen OPs. (pytorch#139026) Pull Request resolved: pytorch#139026 Approved by: https://github.com/EikanWang, https://github.com/desertfire

) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 Pull Request resolved: #140664 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268, #140269

…e load for Intel GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

… GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

…e load for Intel GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

… GPU." Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang aakhundov [ghstack-poisoned]

) Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #140686 * __->__ #140664 * #140269 * #140268 * #135320 * #135318 * #139026 Fix #140546 Pull Request resolved: #140664 Approved by: https://github.com/desertfire, https://github.com/EikanWang ghstack dependencies: #140268, #140269 Co-authored-by: Bin Bao <[email protected]>

Update

5253579

[ghstack-poisoned]

etaf requested review from EikanWang and gujinghui as code owners October 28, 2024 01:23

This was referenced Oct 28, 2024

[Intel GPU] Avoid target_link_libraries twice for torch_xpu_ops which will potentially cause multiple definition symbol linker error. #139024

Closed

[Intel GPU] Support RegisterXPU.cpp codegen and compile for the in-tree XPU structured GEMM OPs. #139025

Closed

etaf mentioned this pull request Oct 10, 2024

[AOTI] Introduce an extensibility mechanism for the c shim codegen to make it easy to produce c shims for out-of-tree OP kernels as well. Add c_shim for XPU. #136742

Closed

pytorch-bot bot added the topic: not user facing topic category label Oct 28, 2024

This was referenced Oct 28, 2024

[AOTI XPU] Enable Cpp wraper for Intel GPU. #135318

Closed

[AOTI XPU] Rename test_cuda_cpp_wrapper.py to test_gpu_cpp_wrapper.py, #135320

Closed

etaf changed the title ~~[AOTI XPU] Update torch-xpu-ops to extend c_shim_xpu layer with~~ [AOTI XPU] Update torch-xpu-ops to extend c_shim_xpu layer with out-of-tree ATen OPs Oct 28, 2024

pytorchbot added the open source label Oct 28, 2024

Update

9afeea5

[ghstack-poisoned]

etaf mentioned this pull request Oct 28, 2024

Add c shim wrapper codegen. intel/torch-xpu-ops#1021

Merged

Update

6ccd70a

[ghstack-poisoned]

etaf marked this pull request as draft October 28, 2024 03:36

Update

be72913

[ghstack-poisoned]

etaf added the ciflow/xpu Run XPU CI tasks label Oct 28, 2024

etaf added 2 commits October 28, 2024 23:17

Update

c4ba187

[ghstack-poisoned]

Update

33137a6

[ghstack-poisoned]

etaf changed the title ~~[AOTI XPU] Update torch-xpu-ops to extend c_shim_xpu layer with out-of-tree ATen OPs~~ [WIP][AOTI XPU] Update torch-xpu-ops to extend c_shim_xpu layer with out-of-tree ATen OPs Oct 30, 2024

etaf added 7 commits October 30, 2024 03:43

Update

6d4a0e6

[ghstack-poisoned]

Update

44a3788

[ghstack-poisoned]

Update

9512684

[ghstack-poisoned]

Update

c97cefe

[ghstack-poisoned]

Update

e2ec38d

[ghstack-poisoned]

Update

43ba9d0

[ghstack-poisoned]

Update

8d0e421

[ghstack-poisoned]

etaf mentioned this pull request Nov 14, 2024

[AOTI] Fix #140546 and support AOTI package load for Intel GPU. #140664

Closed

etaf changed the title ~~[AOTI XPU] Update torch-xpu-ops to extend c_shim_xpu layer with out-of-tree ATen OPs~~ [AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. Nov 14, 2024

etaf marked this pull request as ready for review November 14, 2024 03:44

etaf requested a review from desertfire November 14, 2024 03:44

etaf requested a review from jansel November 14, 2024 06:00

etaf mentioned this pull request Nov 14, 2024

Reuse test cases in test/export for XPU. #140686

Closed

EikanWang approved these changes Nov 14, 2024

View reviewed changes

desertfire approved these changes Nov 14, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2024

pytorchmergebot added the merging label Nov 14, 2024

pytorchmergebot added the Merged label Nov 14, 2024

pytorchmergebot closed this in f4008a5 Nov 14, 2024

pytorchmergebot removed the merging label Nov 14, 2024

github-actions bot deleted the gh/etaf/54/head branch December 15, 2024 02:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. #139026

[AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. #139026

Uh oh!

etaf commented Oct 28, 2024 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 28, 2024 •

edited

Loading

Uh oh!

etaf commented Oct 28, 2024

Uh oh!

EikanWang commented Oct 30, 2024

Uh oh!

etaf commented Nov 14, 2024

Uh oh!

etaf commented Nov 14, 2024

Uh oh!

pytorchmergebot commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. #139026

[AOTI XPU] Remove workarounds after update torch-xpu-ops that extend c_shim_xpu layer with out-of-tree ATen OPs. #139026

Uh oh!

Conversation

etaf commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139026

❗ 1 Active SEVs

✅ No Failures

Uh oh!

etaf commented Oct 28, 2024

Uh oh!

EikanWang commented Oct 30, 2024

Uh oh!

etaf commented Nov 14, 2024

Uh oh!

etaf commented Nov 14, 2024

Uh oh!

pytorchmergebot commented Nov 14, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

etaf commented Oct 28, 2024 •

edited

Loading

pytorch-bot bot commented Oct 28, 2024 •

edited

Loading