Don't uselessly recompute axiom dict every static eval call #138967

laithsakka · 2024-10-26T02:33:40Z

Stack from ghstack (oldest at bottom):

-> Don't uselessly recompute axiom dict every static eval call #138967

Signed-off-by: Edward Z. Yang [email protected]

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec

Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 81ee6b3 Pull Request resolved: #138967

pytorch-bot · 2024-10-26T02:33:45Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138967

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ce53db0 with merge base e3e3ab8 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

laithsakka · 2024-10-30T21:01:14Z

@pytorchbot merge

pytorchmergebot · 2024-10-30T21:03:33Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-10-30T22:28:27Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable)

Details for Dev Infra team

Raised by workflow job

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 0daf338 Pull Request resolved: #138967

laithsakka · 2024-10-31T04:30:16Z

rebase on main

laithsakka · 2024-10-31T05:36:10Z

@pytorchbot merge

pytorchmergebot · 2024-10-31T05:37:54Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

ZainRizvi · 2024-10-31T15:52:42Z

@pytorchbot revert -c weird -m "Sorry, looks like this PR introduced a failure that was incorrectly classified as flaky, and the log classifier didn't identify the right log line either"

The actual failure is:
https://github.com/pytorch/pytorch/actions/runs/11606128745/job/32318311190#step:22:729

WIN: benchmark ('update_hint_regression', 'compile_time_instruction_count') failed, actual result 1743335109 is -2.90% lower than expected 1795333141 ±2.00% please update the expected results. 

please update all results that changed significantly, and not only the failed ones
PASS: benchmark ('sum_floordiv_regression', 'compile_time_instruction_count') pass, actual result 1160229775 +0.53% is within expected 1154135694 ±1.50%

pytorchmergebot · 2024-10-31T15:54:08Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

…138967)" This reverts commit 24b695a. Reverted #138967 on behalf of https://github.com/ZainRizvi due to Sorry, looks like this PR introduced a failure that was incorrectly classified as flaky, and the log classifier didn't identify the right log line either ([comment](#138967 (comment)))

pytorchmergebot · 2024-10-31T15:54:21Z

@laithsakka your PR has been successfully reverted.

Signed-off-by: Edward Z. Yang <ezyangmeta.com> cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames rec [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: f59b078 Pull Request resolved: #138967

laithsakka · 2024-10-31T17:37:52Z

benchmarks/dynamo/pr_time_benchmarks/expected_results.csv

@@ -1,66 +1,65 @@
-add_loop_eager,                compile_time_instruction_count, 3004749893,  0.015


this is the first time the auto generate file is used so thats why all numbers are changed since they are trimmed also.

laithsakka · 2024-10-31T17:38:19Z

@pytorchbot merge

pytorchmergebot · 2024-10-31T17:40:06Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…138967) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#138967 Approved by: https://github.com/ezyang

…ytorch#138967)" This reverts commit 24b695a. Reverted pytorch#138967 on behalf of https://github.com/ZainRizvi due to Sorry, looks like this PR introduced a failure that was incorrectly classified as flaky, and the log classifier didn't identify the right log line either ([comment](pytorch#138967 (comment)))

…138967) Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#138967 Approved by: https://github.com/ezyang

Don't uselessly recompute axiom dict every static eval call

326a49e

Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]

laithsakka added a commit that referenced this pull request Oct 26, 2024

Don't uselessly recompute axiom dict every static eval call

d81fdf6

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 81ee6b3 Pull Request resolved: #138967

pytorch-bot bot added ciflow/inductor module: dynamo labels Oct 26, 2024

pytorch-bot bot added the release notes: fx release notes category label Oct 26, 2024

facebook-github-bot added the fx label Oct 26, 2024

laithsakka marked this pull request as draft October 26, 2024 02:33

laithsakka requested review from bobrenjc93 and ezyang October 30, 2024 20:30

laithsakka marked this pull request as ready for review October 30, 2024 20:31

ezyang approved these changes Oct 30, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 30, 2024

pytorchmergebot added the merging label Oct 30, 2024

pytorchmergebot removed the merging label Oct 30, 2024

laithsakka added a commit that referenced this pull request Oct 31, 2024

Don't uselessly recompute axiom dict every static eval call

8b2d852

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 0daf338 Pull Request resolved: #138967

pytorchmergebot added the merging label Oct 31, 2024

pytorchmergebot added the Merged label Oct 31, 2024

pytorchmergebot closed this in 24b695a Oct 31, 2024

pytorchmergebot removed the merging label Oct 31, 2024

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 31, 2024

pytorchmergebot reopened this Oct 31, 2024

laithsakka added a commit that referenced this pull request Oct 31, 2024

Don't uselessly recompute axiom dict every static eval call

15013d1

Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: f59b078 Pull Request resolved: #138967

laithsakka commented Oct 31, 2024

View reviewed changes

pytorchmergebot added the merging label Oct 31, 2024

laithsakka mentioned this pull request Oct 31, 2024

[inductor] collect memory snapshort in the wrapper #138429

Closed

pytorchmergebot closed this in 6a1c451 Oct 31, 2024

pytorchmergebot removed the merging label Oct 31, 2024

github-actions bot deleted the gh/laithsakka/92/head branch December 1, 2024 02:21

		@@ -1,66 +1,65 @@
		add_loop_eager, compile_time_instruction_count, 3004749893, 0.015

Don't uselessly recompute axiom dict every static eval call #138967

Don't uselessly recompute axiom dict every static eval call #138967

Uh oh!

Conversation

laithsakka commented Oct 26, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138967

✅ No Failures

Uh oh!

laithsakka commented Oct 30, 2024

Uh oh!

pytorchmergebot commented Oct 30, 2024

Merge started

Uh oh!

pytorchmergebot commented Oct 30, 2024

Merge failed

Uh oh!

laithsakka commented Oct 31, 2024

Uh oh!

laithsakka commented Oct 31, 2024

Uh oh!

pytorchmergebot commented Oct 31, 2024

Merge started

Uh oh!

ZainRizvi commented Oct 31, 2024

Uh oh!

pytorchmergebot commented Oct 31, 2024

Uh oh!

pytorchmergebot commented Oct 31, 2024

Uh oh!

laithsakka Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

laithsakka commented Oct 31, 2024

Uh oh!

pytorchmergebot commented Oct 31, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

laithsakka commented Oct 26, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Oct 26, 2024 •

edited

Loading